Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet]: View Steps and Generate API is not disabled on editing Logstash output for user role Settings: Read #191951

Closed
amolnater-qasource opened this issue Sep 3, 2024 · 4 comments · Fixed by #195210
Closed

[Fleet]: View Steps and Generate API is not disabled on editing Logstash output for user role Settings: Read #191951

amolnater-qasource opened this issue Sep 3, 2024 · 4 comments · Fixed by #195210
Assignees
@criamico
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@amolnater-qasource
Copy link

Kibana Build details:

VERSION: 8.16.0 SNAPSHOT
BUILD: 77913
COMMIT: f2aba4624160124344e98dac19d5eefd83fa79ce

Role:

Integrations: All
Fleet: Read
Agents: All
Agent policies: Read
Settings: Read

Image

Preconditions:

  1. 8.16.0-SNAPSHOT Kibana cloud environment should be available.
  2. New User should be created with above defined role.
  3. Logstash should be created with Superuser.

Steps to reproduce:

  1. Login with the above user.
  2. Navigate to Settings>Edit Logstash output.
  3. Observe View Steps and Generate API button is enabled, however it is not required.

Expected Result:
View Steps and Generate API should be disabled on editing Logstash output for user role Settings: Read

Screen Recording:

Settings.-.Fleet.-.Elastic.-.Google.Chrome.2024-09-03.14-00-48.mp4

Feature:
https://github.com/elastic/ingest-dev/issues/2903
@amolnater-qasource amolnater-qasource added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team labels Sep 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@amolnater-qasource
Copy link
Author

@muskangulati-qasource Please review.

@muskangulati-qasource
Copy link

muskangulati-qasource commented Sep 3, 2024 •
edited
Loading

Secondary review for this ticket is Done!

@criamico criamico self-assigned this Oct 7, 2024
@criamico criamico mentioned this issue Oct 7, 2024
Merged
1 task
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 7, 2024
@criamico
[Fleet] Disable button in logstash output based on correct privileges (…
357919c 
…elastic#195210)

Fixes elastic#191951

## Summary
Disable button in logstash output based on correct privileges.

### Testing
- Enable feature flag `subfeaturePrivileges`
- Follow testing steps in above ticket
The button "view steps" in logstash output should be disabled if role
doesn'thave `fleet.allSettings` privileges

![Screenshot 2024-10-07 at 12 03
25](https://github.com/user-attachments/assets/4933fa97-612c-4ddf-abcb-9838b110df09)

![Screenshot 2024-10-07 at 14 48
45](https://github.com/user-attachments/assets/0155480a-a7c5-4274-ab95-57a867b2a1cc)

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 71c8d6f)
@amolnater-qasource amolnater-qasource added the QA:Ready for Testing Code is merged and ready for QA to validate label Oct 8, 2024
@amolnater-qasource
Copy link
Author

Hi Team,

We have revalidated this issue on latest 8.17.0-SNAPSHOT kibana cloud environment and found it fixed now.

Observations:

  • View Steps button is disabled on editing Logstash output for user role Settings: Read.

Build details:
VERSION: 8.17.0 SNAPSHOT
BUILD: 80340
COMMIT: c900805

Screen Recording:

Settings.-.Fleet.-.Elastic.-.Google.Chrome.2024-11-22.12-47-34.mp4

Hence we are marking this issue as QA:Validated.

Thanks!

@amolnater-qasource amolnater-qasource added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@criamico criamico

Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Disable button in logstash output based on correct privileges criamico/kibana
4 participants
@elasticmachine @criamico @muskangulati-qasource @amolnater-qasource