-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] - fix Cypress not running locally #193622
[Security Solution] - fix Cypress not running locally #193622
Conversation
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this workaround in!
ce9caa7
to
6a01a36
Compare
6a01a36
to
8b03a36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks @PhilippeOberti and @michaelolo24 for the fix!
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
(cherry picked from commit f6c5dd9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…#193788) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] - fix Cypress not running locally (#193622)](#193622) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T19:22:11Z","message":"[Security Solution] - fix Cypress not running locally (#193622)","sha":"f6c5dd99c6d67e0ba7846e262a1ef401d3e37f03","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","v8.16.0"],"title":"[Security Solution] - fix Cypress not running locally","number":193622,"url":"https://github.com/elastic/kibana/pull/193622","mergeCommit":{"message":"[Security Solution] - fix Cypress not running locally (#193622)","sha":"f6c5dd99c6d67e0ba7846e262a1ef401d3e37f03"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193622","number":193622,"mergeCommit":{"message":"[Security Solution] - fix Cypress not running locally (#193622)","sha":"f6c5dd99c6d67e0ba7846e262a1ef401d3e37f03"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <[email protected]>
Summary
This PR fixes Cypress not working when ran locally (and the error seems to also happen on Buildkite).
What happened
During on-week back in mid August, the Threat Intelligence Cypress tests were moved to the
security_solution_cypress
folder and all the tests were enabled again. The PR was only merged 3 weeks later, on the 10th of September. In between, another PR was merged, then reverted then merged again.I'm not sure exactly how these PRs impacted each other...
This PR fixes the issue with Cypress not working while keeping the Threat Intelligence Cypress tests (and all the other ones obviously) working! 😄 Thank you @michaelolo24 for providing the code to fix the issue!