Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[FTR] Refactor test/common/services/* -> packages/kbn-ftr-com… #191765

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Aug 29, 2024

@jbudz
Copy link
Member Author

jbudz commented Aug 29, 2024

buildkite test this

Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@jbudz jbudz marked this pull request as ready for review August 29, 2024 21:05
@jbudz jbudz requested review from a team as code owners August 29, 2024 21:05
@jbudz jbudz added the release_note:skip Skip the PR/issue when compiling release notes label Aug 29, 2024
@jbudz jbudz merged commit 9f70009 into elastic:main Aug 29, 2024
27 of 29 checks passed
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 29, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ftr-common-functional-services 69 32 -37
@kbn/ftr-common-functional-ui-services 520 511 -9
total -46

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/ftr-common-functional-ui-services 7 3 -4
Unknown metric groups

API count

id before after diff
@kbn/ftr-common-functional-services 94 47 -47
@kbn/ftr-common-functional-ui-services 560 551 -9
total -56

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

wayneseymour added a commit that referenced this pull request Sep 5, 2024
…tional-[ui-]services/* (#191805)

## Summary

Moving common services to respective new homes.

This PR is revived from a previously
[merged](09a3658)
and [reverted PR](#191765) as
[detailed
here](#189051 (comment)).
- This was due to "extra" tests being applied to
#191708
- These "extra" tests were applied as
#191708 changes files within
`x-pack/plugins/observability_solution/` as configured
[here](https://github.com/elastic/kibana/blob/main/.buildkite/scripts/pipelines/pull_request/pipeline.ts#L129)

### Why these failures were not caught in the original
[PR](#189051)
The pipeline is generated at runtime, and the original
[PR](#189051) had zero changes
under `x-pack/plugins/observability_solution/`
 
 ## Changes on top of original PR
 - Add `ci:all-cypress-suites` label to run extra tests
- Add `services` stanza to which contains the missing references by
spreading the services from `@kbn/ftr-common-functional-services` &&
`@kbn/ftr-common-functional-ui-services` into the stanza, for the
following:
   - `x-pack/plugins/observability_solution/synthetics/e2e/config.ts`
   - `x-pack/plugins/observability_solution/apm/ftr_e2e/ftr_config.ts` 
-
`x-pack/plugins/observability_solution/observability_onboarding/e2e/ftr_config.ts`
   - `x-pack/plugins/observability_solution/profiling/e2e/ftr_config.ts`
   - `x-pack/plugins/observability_solution/synthetics/e2e/config.ts`
   - `x-pack/plugins/observability_solution/uptime/e2e/config.ts`
 

 
 
Blocked by: #191961
Resolves: #188541

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants