Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Report uptime overview metrics #191708

Merged
merged 6 commits into from
Aug 30, 2024

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Aug 29, 2024

Summary

Report uptime overview metrics !!

@shahzad31 shahzad31 requested review from a team as code owners August 29, 2024 09:33
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Aug 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 added the release_note:skip Skip the PR/issue when compiling release notes label Aug 29, 2024
@shahzad31 shahzad31 removed the request for review from a team August 29, 2024 15:39
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More perf tracking 💪🏻

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 29, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: b8fc7da
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-191708-b8fc7da93f51

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
uptime 590 599 +9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 467.9KB 469.9KB +2.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
uptime 22.6KB 22.6KB +61.0B
Unknown metric groups

async chunk count

id before after diff
uptime 16 17 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 9ea0f06 into elastic:main Aug 30, 2024
22 checks passed
@shahzad31 shahzad31 deleted the perf-uptime-overview branch August 30, 2024 06:14
@shahzad31 shahzad31 added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed v8.16.0 labels Aug 30, 2024
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.15 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 191708

Questions ?

Please refer to the Backport tool documentation

@shahzad31 shahzad31 removed the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Sep 5, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 5, 2024
@shahzad31 shahzad31 added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Sep 5, 2024
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.15 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 191708

Questions ?

Please refer to the Backport tool documentation

@shahzad31
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

shahzad31 added a commit to shahzad31/kibana that referenced this pull request Sep 5, 2024
## Summary

 Report uptime overview metrics !!

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 9ea0f06)

# Conflicts:
#	x-pack/plugins/observability_solution/uptime/tsconfig.json
wayneseymour added a commit that referenced this pull request Sep 5, 2024
…tional-[ui-]services/* (#191805)

## Summary

Moving common services to respective new homes.

This PR is revived from a previously
[merged](09a3658)
and [reverted PR](#191765) as
[detailed
here](#189051 (comment)).
- This was due to "extra" tests being applied to
#191708
- These "extra" tests were applied as
#191708 changes files within
`x-pack/plugins/observability_solution/` as configured
[here](https://github.com/elastic/kibana/blob/main/.buildkite/scripts/pipelines/pull_request/pipeline.ts#L129)

### Why these failures were not caught in the original
[PR](#189051)
The pipeline is generated at runtime, and the original
[PR](#189051) had zero changes
under `x-pack/plugins/observability_solution/`
 
 ## Changes on top of original PR
 - Add `ci:all-cypress-suites` label to run extra tests
- Add `services` stanza to which contains the missing references by
spreading the services from `@kbn/ftr-common-functional-services` &&
`@kbn/ftr-common-functional-ui-services` into the stanza, for the
following:
   - `x-pack/plugins/observability_solution/synthetics/e2e/config.ts`
   - `x-pack/plugins/observability_solution/apm/ftr_e2e/ftr_config.ts` 
-
`x-pack/plugins/observability_solution/observability_onboarding/e2e/ftr_config.ts`
   - `x-pack/plugins/observability_solution/profiling/e2e/ftr_config.ts`
   - `x-pack/plugins/observability_solution/synthetics/e2e/config.ts`
   - `x-pack/plugins/observability_solution/uptime/e2e/config.ts`
 

 
 
Blocked by: #191961
Resolves: #188541

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
shahzad31 added a commit that referenced this pull request Sep 5, 2024
# Backport

This will backport the following commits from `main` to `8.15`:
- [[Uptime] Report uptime overview metrics
(#191708)](#191708)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-08-30T06:14:05Z","message":"[Uptime]
Report uptime overview metrics (#191708)\n\n## Summary\r\n\r\n Report
uptime overview metrics !!\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"9ea0f06a8ec5d504c0d1096d0cef551572730601","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0"],"number":191708,"url":"https://github.com/elastic/kibana/pull/191708","mergeCommit":{"message":"[Uptime]
Report uptime overview metrics (#191708)\n\n## Summary\r\n\r\n Report
uptime overview metrics !!\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"9ea0f06a8ec5d504c0d1096d0cef551572730601"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191708","number":191708,"mergeCommit":{"message":"[Uptime]
Report uptime overview metrics (#191708)\n\n## Summary\r\n\r\n Report
uptime overview metrics !!\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"9ea0f06a8ec5d504c0d1096d0cef551572730601"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.15.1 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants