-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] migrate Threat Intelligence Cypress tests into security_solution_cypress folder #191162
[Security Solution] migrate Threat Intelligence Cypress tests into security_solution_cypress folder #191162
Conversation
b820920
to
1c6d069
Compare
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6804[❌] Security Solution Investigations - Cypress: 0/25 tests passed. |
1c6d069
to
aa93791
Compare
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6805[✅] [Serverless] Security Solution Investigations - Cypress: 25/25 tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes to the plugin manifest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking okay, we finally have something working here again :) thanks!
…curity_solution_cypress folder
This reverts commit 3867f2a.
aa93791
to
97d994b
Compare
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
This PR is the first of 3 that aims at migrating all the Threat Intelligence Cypress tests to the
security_solution_cypress
folder. The goal is to re-enable the Threat Intelligence tests that have been skipped for months now, which has lead to many issues that were covered by those tests not being detected...This PR covers:
security_solution_cypress
folder within the existinginvestigations
folder, to ensure they're running alongside all the other tests owned by the @elastic/security-threat-hunting-investigations teamgetDataTestSubjectSelector
function wherever possibleforce: true
andshould('exist')
orshould('be.visible')
as well asscrollIntoView
codeThe next 2 PRS will tackle the following:
plugins/threat_intelligence
folder as well as all the code under thetest/threat_intelligence_cypress
folder)Checklist
✅ Flaky Test Runner all passed here https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6805
#171778
#171779
#171780
#171781
#171783
#171784
#171785
#171786
It also fixes this bug