Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] migrate Threat Intelligence Cypress tests into security_solution_cypress folder #191162

Conversation

PhilippeOberti
Copy link
Contributor

@PhilippeOberti PhilippeOberti commented Aug 23, 2024

Summary

This PR is the first of 3 that aims at migrating all the Threat Intelligence Cypress tests to the security_solution_cypress folder. The goal is to re-enable the Threat Intelligence tests that have been skipped for months now, which has lead to many issues that were covered by those tests not being detected...

This PR covers:

  • add all the tests to the security_solution_cypress folder within the existing investigations folder, to ensure they're running alongside all the other tests owned by the @elastic/security-threat-hunting-investigations team
  • improve and augment tests whenever possible
  • use the getDataTestSubjectSelector function wherever possible
  • replace all imports of test ids with their actual values to avoid weird circular dependencies issues
  • divide the existing archives into multiple smaller ones to reduce load times as well as the size of each file
  • remove unwanted force: true and should('exist') or should('be.visible') as well as scrollIntoView code

The next 2 PRS will tackle the following:

  • delete all the old tests (within the plugins/threat_intelligence folder as well as all the code under the test/threat_intelligence_cypress folder)

Checklist


#171778
#171779
#171780
#171781
#171783
#171784
#171785
#171786
It also fixes this bug

@PhilippeOberti PhilippeOberti force-pushed the ti-cypess-in-security_solution_cypress-part-1 branch 2 times, most recently from b820920 to 1c6d069 Compare August 23, 2024 18:49
@elastic elastic deleted a comment from kibana-ci Aug 23, 2024
@PhilippeOberti PhilippeOberti marked this pull request as ready for review August 23, 2024 20:29
@PhilippeOberti PhilippeOberti requested review from a team as code owners August 23, 2024 20:29
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6804

[❌] Security Solution Investigations - Cypress: 0/25 tests passed.

see run history

@PhilippeOberti PhilippeOberti force-pushed the ti-cypess-in-security_solution_cypress-part-1 branch from 1c6d069 to aa93791 Compare August 26, 2024 06:52
@PhilippeOberti PhilippeOberti added release_note:skip Skip the PR/issue when compiling release notes v8.16.0 Team:Threat Hunting:Investigations Security Solution Investigations Team labels Aug 26, 2024
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6805

[✅] [Serverless] Security Solution Investigations - Cypress: 25/25 tests passed.

see run history

Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to the plugin manifest LGTM

Copy link
Contributor

@lgestc lgestc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking okay, we finally have something working here again :) thanks!

@PhilippeOberti PhilippeOberti force-pushed the ti-cypess-in-security_solution_cypress-part-1 branch from aa93791 to 97d994b Compare September 10, 2024 22:49
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #229668 succeeded aa937911473277a691faacf3939546e00e0def48
  • 💚 Build #229580 succeeded 1c6d069f4900cec7c45fdf726a609b0e60ba988e
  • 💛 Build #229571 was flaky 1c6d069f4900cec7c45fdf726a609b0e60ba988e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.16.0
Projects
None yet
6 participants