[Logs Explorer] Add logic to render degraded fields table in Logs Flyout #186287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achyutjhunjhunwala
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
/ci |
|
/ci |
|
/ci |
|
/ci |
💔 Build FailedFailed CI StepsHistory
To update your PR or re-run it, just comment with: |
achyutjhunjhunwala
added a commit
that referenced
this pull request
Jul 4, 2024
… main DQ Page page (#187450) ## Summary This PR is a prerequisite to the Locator Implementation for Logs Explorer - #186287 ## Problem Statement - Integrations were fetched when the main DQ page loads and stored in the State Machine. This means when the Flyout Opens, it was referencing already fetched data from the main page, updating the URL and then that was used to render certain sections on the Flyout. This causes issues as when a Locator is used to directly open the Flyout from some other page. In that case everything happen asynchronously causing the data to be not present when the flyout open thus those integration sections were not present. ## Solution - Now when the flyout is opened or is already open, it reads the basic params from the URL like `DataStream`. With this information, it make API call to fetch Integration information and thus making it independent. - Does this means you duplicated the Logic to fetch Integrations ? Yes and No. Logic has to be duplicated as Flyout is moving to its own page very soon. This means it would anyhow not be able to re-use that Integration Information available. Secondly the duplication is not one to one, its more catered towards Flyout logic - Split the state machine to make Integration Calls only when the opened Dataset is actually an integration. This is done by chaining the respective states after the `DataStreamSettings` state confirms presence of Integration. ## What else has been done - Type cleaning: A lot of types has to be refactored to make this change. Also simplified some duplicate types. We were using - Runtime types - Types Derived from Runtime Types - Inferred Types from API Responses We don't need the 3rd one. 1 and 2 and sufficient.
|
/ci |
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
botelastic
bot
added
the
ci:project-deploy-observability
pgayvallet
approved these changes
Jul 4, 2024
kertal
reviewed
Jul 4, 2024
Comment on lines
35
to
38
| "@kbn/core-notifications-browser", | ||
| "@kbn/deeplinks-observability", | ||
| "@kbn/router-utils", | ||
| "@kbn/share-plugin" |
There was a problem hiding this comment.
QQ: just looked at the code we own, it seems there's just the share plugin being added, why are
"@kbn/deeplinks-observability",
"@kbn/router-utils"
required? thx
There was a problem hiding this comment.
That's actually a very good question.
@kbn/deeplinks-observability is being imported here
But i couldn't myself find why "@kbn/router-utils" got added. I thought job would have added it. But looks like not. I will remove this
yngrdyn
reviewed
Jul 5, 2024
yngrdyn
reviewed
Jul 5, 2024
⏳ Build in-progress
History
|
kertal
approved these changes
Jul 9, 2024
kibanamachine
added
v8.16.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes - #172272
The PR adds the degraded Field Table in the Logs Flyout. The accordion is kept closed by default. For demo purposes below screenshot will show it expanded
This PR will also fix a very simply Flaky Test - #186244
Pending Items
Demo