-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataset Quality] Refactor integrations in DQ Flyout to not depend on main DQ Page page #187450
Merged
achyutjhunjhunwala
merged 24 commits into
elastic:main
from
achyutjhunjhunwala:refactor-integrations-to-not-depend-on-main-page
Jul 4, 2024
Merged
[Dataset Quality] Refactor integrations in DQ Flyout to not depend on main DQ Page page #187450
achyutjhunjhunwala
merged 24 commits into
elastic:main
from
achyutjhunjhunwala:refactor-integrations-to-not-depend-on-main-page
Jul 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achyutjhunjhunwala
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:obs-ux-logs
Observability Logs User Experience Team
Feature:Dataset Health
labels
Jul 3, 2024
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
botelastic
bot
added
the
ci:project-deploy-observability
Create an Observability project
label
Jul 3, 2024
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
achyutjhunjhunwala
changed the title
[Dataset Quality] Refactor integrations to not depend on main page
[Dataset Quality] Refactor integrations in DQ Flyout to not depend on main DQ Page page
Jul 3, 2024
yngrdyn
reviewed
Jul 3, 2024
...lution/dataset_quality/public/state_machines/dataset_quality_controller/src/notifications.ts
Outdated
Show resolved
Hide resolved
yngrdyn
reviewed
Jul 3, 2024
x-pack/plugins/observability_solution/dataset_quality/common/data_stream_details/types.ts
Outdated
Show resolved
Hide resolved
yngrdyn
reviewed
Jul 3, 2024
x-pack/plugins/observability_solution/dataset_quality/common/api_types.ts
Outdated
Show resolved
Hide resolved
yngrdyn
reviewed
Jul 3, 2024
x-pack/plugins/observability_solution/dataset_quality/common/data_streams_stats/integration.ts
Show resolved
Hide resolved
yngrdyn
reviewed
Jul 3, 2024
x-pack/plugins/observability_solution/dataset_quality/common/types/common.ts
Outdated
Show resolved
Hide resolved
yngrdyn
reviewed
Jul 3, 2024
x-pack/plugins/observability_solution/dataset_quality/public/components/flyout/flyout.tsx
Outdated
Show resolved
Hide resolved
yngrdyn
reviewed
Jul 3, 2024
...lution/dataset_quality/public/state_machines/dataset_quality_controller/src/state_machine.ts
Outdated
Show resolved
Hide resolved
yngrdyn
reviewed
Jul 3, 2024
...lution/dataset_quality/public/state_machines/dataset_quality_controller/src/state_machine.ts
Outdated
Show resolved
Hide resolved
…tegrations have loaded
yngrdyn
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
|
kibanamachine
added
v8.15.0
backport:skip
This commit does not require backporting
labels
Jul 4, 2024
achyutjhunjhunwala
deleted the
refactor-integrations-to-not-depend-on-main-page
branch
July 4, 2024 11:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
ci:project-deploy-observability
Create an Observability project
Feature:Dataset Health
release_note:skip
Skip the PR/issue when compiling release notes
Team:obs-ux-logs
Observability Logs User Experience Team
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a prerequisite to the Locator Implementation for Logs Explorer - #186287
Problem Statement
Solution
DataStream
. With this information, it make API call to fetch Integration information and thus making it independent.DataStreamSettings
state confirms presence of Integration.What else has been done
We don't need the 3rd one. 1 and 2 and sufficient.