Merge branch 'main' into Add-quality-issues-table-to-Logs-Flyout

elastic · Jun 17, 2024 · d4852ad · d4852ad
2 parents ae4bfba + 96024b8
commit d4852ad
Show file tree

Hide file tree

Showing 16 changed files with 1,486 additions and 1,330 deletions.
diff --git a/.buildkite/scripts/pipelines/pull_request/pipeline.ts b/.buildkite/scripts/pipelines/pull_request/pipeline.ts
@@ -145,15 +145,14 @@ const getPipeline = (filename: string, removeSteps = true) => {
       pipeline.push(getPipeline('.buildkite/pipelines/pull_request/fips.yml'));
     }
 
-    if (GITHUB_PR_LABELS.includes('ci:build-serverless-image')) {
-      pipeline.push(getPipeline('.buildkite/pipelines/pull_request/build_project.yml'));
-    }
     if (
       GITHUB_PR_LABELS.includes('ci:project-deploy-elasticsearch') ||
       GITHUB_PR_LABELS.includes('ci:project-deploy-observability') ||
       GITHUB_PR_LABELS.includes('ci:project-deploy-security')
     ) {
       pipeline.push(getPipeline('.buildkite/pipelines/pull_request/deploy_project.yml'));
+    } else if (GITHUB_PR_LABELS.includes('ci:build-serverless-image')) {
+      pipeline.push(getPipeline('.buildkite/pipelines/pull_request/build_project.yml'));
     }
 
     if (

diff --git a/dev_docs/tutorials/performance/adding_custom_performance_metrics.mdx b/dev_docs/tutorials/performance/adding_custom_performance_metrics.mdx
@@ -3,7 +3,6 @@ id: kibDevTutorialAddingCustomPerformanceMetrics
 slug: /kibana-dev-docs/tutorial/performance/adding_custom_performance_metrics
 title: Adding Performance Metrics
 summary: Learn how to instrument your code and analyze performance
-date: 2023-01-13
 tags: ['kibana', 'onboarding', 'setup', 'performance', 'development', 'telemetry']
 ---
 
@@ -241,7 +240,7 @@ const MyApp = () => {
       if (fetchedData.status === 'success') {
       setData(fetchedData);
 
-      // Call onPageReady once the meaningful data has rendered and visible to the user 
+      // Call onPageReady once the meaningful data has rendered and visible to the user
 
         onPageReady();
       }

diff --git a/nav-kibana-dev.docnav.json b/nav-kibana-dev.docnav.json
@@ -115,7 +115,8 @@
       "label": "Tutorials",
       "items": [
         {
-          "id": "kibDevTutorialAddingCustomPerformanceMetrics"
+          "id": "kibDevTutorialAddingCustomPerformanceMetrics",
+          "label": "Adding Performance Metrics"
         },
         {
           "id": "kibDevTutorialSetupWindowsDevWSL"

diff --git a/packages/kbn-esql-ast/src/antlr/esql_lexer.g4 b/packages/kbn-esql-ast/src/antlr/esql_lexer.g4
@@ -166,6 +166,11 @@ ASTERISK : '*';
 SLASH : '/';
 PERCENT : '%';
 
+NAMED_OR_POSITIONAL_PARAM
+    : PARAM LETTER UNQUOTED_ID_BODY*
+    | PARAM DIGIT+
+    ;
+
 // Brackets are funny. We can happen upon a CLOSING_BRACKET in two ways - one
 // way is to start in an explain command which then shifts us to expression
 // mode. Thus, the two popModes on CLOSING_BRACKET. The other way could as

diff --git a/packages/kbn-esql-ast/src/antlr/esql_lexer.interp b/packages/kbn-esql-ast/src/antlr/esql_lexer.interp
diff --git a/packages/kbn-esql-ast/src/antlr/esql_lexer.tokens b/packages/kbn-esql-ast/src/antlr/esql_lexer.tokens
@@ -65,62 +65,63 @@ MINUS=64
 ASTERISK=65
 SLASH=66
 PERCENT=67
-OPENING_BRACKET=68
-CLOSING_BRACKET=69
-UNQUOTED_IDENTIFIER=70
-QUOTED_IDENTIFIER=71
-EXPR_LINE_COMMENT=72
-EXPR_MULTILINE_COMMENT=73
-EXPR_WS=74
-METADATA=75
-FROM_LINE_COMMENT=76
-FROM_MULTILINE_COMMENT=77
-FROM_WS=78
-ID_PATTERN=79
-PROJECT_LINE_COMMENT=80
-PROJECT_MULTILINE_COMMENT=81
-PROJECT_WS=82
-AS=83
-RENAME_LINE_COMMENT=84
-RENAME_MULTILINE_COMMENT=85
-RENAME_WS=86
-ON=87
-WITH=88
-ENRICH_POLICY_NAME=89
-ENRICH_LINE_COMMENT=90
-ENRICH_MULTILINE_COMMENT=91
-ENRICH_WS=92
-ENRICH_FIELD_LINE_COMMENT=93
-ENRICH_FIELD_MULTILINE_COMMENT=94
-ENRICH_FIELD_WS=95
-LOOKUP_LINE_COMMENT=96
-LOOKUP_MULTILINE_COMMENT=97
-LOOKUP_WS=98
-LOOKUP_FIELD_LINE_COMMENT=99
-LOOKUP_FIELD_MULTILINE_COMMENT=100
-LOOKUP_FIELD_WS=101
-MVEXPAND_LINE_COMMENT=102
-MVEXPAND_MULTILINE_COMMENT=103
-MVEXPAND_WS=104
-INFO=105
-SHOW_LINE_COMMENT=106
-SHOW_MULTILINE_COMMENT=107
-SHOW_WS=108
-FUNCTIONS=109
-META_LINE_COMMENT=110
-META_MULTILINE_COMMENT=111
-META_WS=112
-COLON=113
-SETTING=114
-SETTING_LINE_COMMENT=115
-SETTTING_MULTILINE_COMMENT=116
-SETTING_WS=117
-METRICS_LINE_COMMENT=118
-METRICS_MULTILINE_COMMENT=119
-METRICS_WS=120
-CLOSING_METRICS_LINE_COMMENT=121
-CLOSING_METRICS_MULTILINE_COMMENT=122
-CLOSING_METRICS_WS=123
+NAMED_OR_POSITIONAL_PARAM=68
+OPENING_BRACKET=69
+CLOSING_BRACKET=70
+UNQUOTED_IDENTIFIER=71
+QUOTED_IDENTIFIER=72
+EXPR_LINE_COMMENT=73
+EXPR_MULTILINE_COMMENT=74
+EXPR_WS=75
+METADATA=76
+FROM_LINE_COMMENT=77
+FROM_MULTILINE_COMMENT=78
+FROM_WS=79
+ID_PATTERN=80
+PROJECT_LINE_COMMENT=81
+PROJECT_MULTILINE_COMMENT=82
+PROJECT_WS=83
+AS=84
+RENAME_LINE_COMMENT=85
+RENAME_MULTILINE_COMMENT=86
+RENAME_WS=87
+ON=88
+WITH=89
+ENRICH_POLICY_NAME=90
+ENRICH_LINE_COMMENT=91
+ENRICH_MULTILINE_COMMENT=92
+ENRICH_WS=93
+ENRICH_FIELD_LINE_COMMENT=94
+ENRICH_FIELD_MULTILINE_COMMENT=95
+ENRICH_FIELD_WS=96
+LOOKUP_LINE_COMMENT=97
+LOOKUP_MULTILINE_COMMENT=98
+LOOKUP_WS=99
+LOOKUP_FIELD_LINE_COMMENT=100
+LOOKUP_FIELD_MULTILINE_COMMENT=101
+LOOKUP_FIELD_WS=102
+MVEXPAND_LINE_COMMENT=103
+MVEXPAND_MULTILINE_COMMENT=104
+MVEXPAND_WS=105
+INFO=106
+SHOW_LINE_COMMENT=107
+SHOW_MULTILINE_COMMENT=108
+SHOW_WS=109
+FUNCTIONS=110
+META_LINE_COMMENT=111
+META_MULTILINE_COMMENT=112
+META_WS=113
+COLON=114
+SETTING=115
+SETTING_LINE_COMMENT=116
+SETTTING_MULTILINE_COMMENT=117
+SETTING_WS=118
+METRICS_LINE_COMMENT=119
+METRICS_MULTILINE_COMMENT=120
+METRICS_WS=121
+CLOSING_METRICS_LINE_COMMENT=122
+CLOSING_METRICS_MULTILINE_COMMENT=123
+CLOSING_METRICS_WS=124
 'dissect'=1
 'drop'=2
 'enrich'=3
@@ -177,11 +178,11 @@ CLOSING_METRICS_WS=123
 '*'=65
 '/'=66
 '%'=67
-']'=69
-'metadata'=75
-'as'=83
-'on'=87
-'with'=88
-'info'=105
-'functions'=109
-':'=113
+']'=70
+'metadata'=76
+'as'=84
+'on'=88
+'with'=89
+'info'=106
+'functions'=110
+':'=114