Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] - Rename esql setting #182432

Merged
merged 3 commits into from
May 2, 2024
Merged

[Security Solution] - Rename esql setting #182432

merged 3 commits into from
May 2, 2024
+7 −1

Conversation

michaelolo24
Copy link
Contributor

@michaelolo24 michaelolo24 commented May 2, 2024 •
edited by kibanamachine
Loading

Summary

Follow up to this PR: #181616
Renaming discover:enableEsql to enableESQL according to this change: #182074

@michaelolo24 michaelolo24 added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.14.0 v8.15.0 labels May 2, 2024
@michaelolo24 michaelolo24 added this to the 8.14 milestone May 2, 2024
@michaelolo24 michaelolo24 requested a review from a team as a code owner May 2, 2024 17:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@michaelolo24 michaelolo24 enabled auto-merge (squash) May 2, 2024 17:23
vitaliidm
vitaliidm reviewed May 2, 2024
View reviewed changes
x-pack/plugins/security_solution/public/common/hooks/esql/use_esql_availability.ts Outdated
export const useEsqlAvailability = () => {
const { uiSettings } = useKibana().services;
const isEsqlAdvancedSettingEnabled = uiSettings?.get('discover:enableESQL');
const isEsqlAdvancedSettingEnabled = uiSettings?.get('enableESQL');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can use const variable according to #181616 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, agreed. Done, just rushed a little to make BC3, but updated as I think we should be okay 😄

@michaelolo24 michaelolo24 force-pushed the rename-esql-setting branch from 3600d48 to 06db5f9 Compare May 2, 2024 19:04
@jbudz jbudz disabled auto-merge May 2, 2024 19:18
@jbudz jbudz merged commit c053208 into elastic:main May 2, 2024
3 of 7 checks passed
@jbudz jbudz mentioned this pull request May 2, 2024
Merged
This was referenced May 2, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Closed
@kibana-ci
Copy link
Collaborator

kibana-ci commented May 2, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #11 / Rules Management - Rule Bulk Action API @ess perform_bulk_action - ESS specific logic should enable rules and migrate actions
  • [job] [logs] FTR Configs #11 / Rules Management - Rule Bulk Action API @ess perform_bulk_action - ESS specific logic should enable rules and migrate actions

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.7MB 13.7MB +651.0B

History

  • 💔 Build #207617 failed 3600d4853e336468ddc979ebc6a3b0c2c60320dd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine mentioned this pull request May 3, 2024
Merged
@nastasha-solomon nastasha-solomon mentioned this pull request May 5, 2024
Closed
@banderror banderror mentioned this pull request May 6, 2024
Open
This was referenced May 6, 2024
Open
Closed
Closed
Closed
Closed
Open
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 3, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

8 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 182432 locally

@jbudz jbudz added the backport:skip This commit does not require backporting label Sep 30, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaliidm vitaliidm vitaliidm approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.14.0 v8.15.0
Projects
None yet
Milestone
8.14
Development

Successfully merging this pull request may close these issues.
6 participants
@michaelolo24 @elasticmachine @kibana-ci @kibanamachine @vitaliidm @jbudz