[Security Solution] Fix assistant settings availability for non-superuser role #182322

YulNaumenko · 2024-05-02T04:13:20Z

…user role

…fix'

semd · 2024-05-02T09:01:51Z

Hey @YulNaumenko, the config overall looks good, the original problem is solved (for stateful). I tested the branch locally, it works as expected so I am going to approve it.

However, I noticed some things:

License: The AI assistants link in the management navigation is visible, and Security settings are editable, regardless of the license being used (I tested with Platinum license, I could not use the AI assistant, but I could edit its settings). Should we align the behavior regarding the license?
Serverless: It is possible to access app/management/kibana/securityAiAssistantManagement from the global search, but there's no link to it anywhere in the entire application, would it make sense to add a "custom" card link to the management landing? (after checking the product type being used)
Features: The privilege to use the Security AI assistant is under the "Security" catalog, but to edit the setting a user needs a privilege that is under the "Management" catalog, wouldn't it be more consistent if the Security AI assistant feature enabled the securityAiAssistantManagement management flag. So a user would need both the Security and the Management "AI assistant" features to edit the Security AI assistant settings? (same for O11y)

semd

LGTM!

CoenWarmer

LGTM

kdelemme

Obs UI changes LGTM

azasypkin

LGTM, just left few non-blocking questions.

azasypkin · 2024-05-02T16:07:08Z

src/plugins/ai_assistant_management/selection/kibana.jsonc

@@ -7,7 +7,7 @@
    "server": true,
    "browser": true,
    "requiredPlugins": ["management"],
-    "optionalPlugins": ["home", "serverless"],
+    "optionalPlugins": ["home", "serverless", "features"],


question: cannot we make features plugin required?

azasypkin · 2024-05-02T16:09:28Z

src/plugins/ai_assistant_management/selection/server/plugin.ts

+      };
+    });
+
+    plugins.features?.registerKibanaFeature({


question: I'm not sure if this plugin is enabled in Serverless, but if it's - should this feature be available in Serverless role management UI? If so, for which project types (Security, Search, Observability)?

jbudz · 2024-05-02T19:21:25Z

Sorry, updating once more to include #182432 and fix the timeouts shown in the previous build

kibana-ci · 2024-05-02T21:44:23Z

💚 Build Succeeded

Buildkite Build
Commit: b8df2e4

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`aiAssistantManagementSelection`	4.3KB	4.4KB	+18.0B
`navigation`	31.1KB	31.2KB	+102.0B
`securitySolutionEss`	15.5KB	15.5KB	+51.0B
total			+171.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/saved-objects-service.html#_mappings

id	before	after	diff
`_ignored_source`	1	-	-1

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`aiAssistantManagementSelection`	6	5	-1

Total ESLint disabled count

id	before	after	diff
`aiAssistantManagementSelection`	6	5	-1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @YulNaumenko

…user role (elastic#182322) Resolves elastic#182209 --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 9d7dfea)

kibanamachine · 2024-05-02T21:48:51Z

💚 All backports created successfully

Status	Branch	Result
✅	8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…n-superuser role (#182322) (#182528) # Backport This will backport the following commits from `main` to `8.14`: - [[Security Solution] Fix assistant settings availability for non-superuser role (#182322)](#182322)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Yuliia Naumenko <[email protected]>

azasypkin · 2024-05-03T08:39:20Z

src/plugins/ai_assistant_management/selection/server/plugin.ts

@@ -79,6 +86,66 @@ export class AIAssistantManagementSelectionPlugin
      },
    });

+    core.capabilities.registerProvider(() => {


note: forgot to comment on this one yesterday - I don't think we need this here - I believe it's only needed when the feature/plugin can be used with Elastic Stack security disabled which is unlikely to be the case for this plugin.

YulNaumenko added 9 commits March 27, 2024 21:16

[Security AI Assistant] Improve clear conversation requests efficiency.

d54982e

Merge remote-tracking branch 'upstream/main'

37d4136

Merge remote-tracking branch 'upstream/main'

9cbb124

Merge remote-tracking branch 'upstream/main'

6bdfa7c

Merge remote-tracking branch 'upstream/main'

845589c

Merge remote-tracking branch 'upstream/main'

6f72d06

Merge remote-tracking branch 'upstream/main'

38a4a33

Merge remote-tracking branch 'upstream/main'

a19ec28

[Security Solution] Fix assistant settings availability for non-super…

95d84c4

…user role

YulNaumenko requested review from a team as code owners May 2, 2024 04:13

YulNaumenko requested a review from a team May 2, 2024 04:13

YulNaumenko requested review from a team as code owners May 2, 2024 04:13

YulNaumenko and others added 2 commits May 1, 2024 22:01

fixed priviledges

445444f

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

a050ffd

…fix'

YulNaumenko self-assigned this May 2, 2024

YulNaumenko added v8.14.0 bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes labels May 2, 2024

YulNaumenko removed the request for review from a team May 2, 2024 05:09

pgayvallet approved these changes May 2, 2024

View reviewed changes

semd approved these changes May 2, 2024

View reviewed changes

sebelga approved these changes May 2, 2024

View reviewed changes

stephmilovic added the v8.15.0 label May 2, 2024

YulNaumenko added 2 commits May 2, 2024 08:07

made features plugin optional

c16cc20

fixed ftr tests

be414d5

YulNaumenko requested a review from a team as a code owner May 2, 2024 15:25

CoenWarmer approved these changes May 2, 2024

View reviewed changes

kdelemme approved these changes May 2, 2024

View reviewed changes

shahzad31 approved these changes May 2, 2024

View reviewed changes

azasypkin approved these changes May 2, 2024

View reviewed changes

YulNaumenko enabled auto-merge (squash) May 2, 2024 16:15

more tests

0867041

YulNaumenko requested a review from a team as a code owner May 2, 2024 17:08

YulNaumenko added 2 commits May 2, 2024 10:12

Merge branch 'main' into security-ai-assistant-setting-privilege-bug

1c34370

revert test fix

bc56a95

YulNaumenko removed the request for review from a team May 2, 2024 17:16

Merge branch 'main' into security-ai-assistant-setting-privilege-bug

f37afe6

TattdCodeMonkey approved these changes May 2, 2024

View reviewed changes

Merge branch 'main' into security-ai-assistant-setting-privilege-bug

9ccd510

jbudz and others added 2 commits May 2, 2024 14:21

Merge branch 'main' into security-ai-assistant-setting-privilege-bug

296620c

Merge branch 'main' into security-ai-assistant-setting-privilege-bug

b8df2e4

YulNaumenko merged commit 9d7dfea into elastic:main May 2, 2024
36 checks passed

kibanamachine mentioned this pull request May 2, 2024

[8.14] [Security Solution] Fix assistant settings availability for non-superuser role (#182322) #182528

Merged

azasypkin reviewed May 3, 2024

View reviewed changes

szaffarano mentioned this pull request Jul 12, 2024

[8.14] [Telemetry][Security Solution] Use the proper index to query builtin alerts (#187859) #188233

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Fix assistant settings availability for non-superuser role #182322

[Security Solution] Fix assistant settings availability for non-superuser role #182322

YulNaumenko commented May 2, 2024 •

edited by kibanamachine

Loading

semd commented May 2, 2024 •

edited

Loading

semd left a comment

CoenWarmer left a comment

kdelemme left a comment

azasypkin left a comment

azasypkin May 2, 2024

azasypkin May 2, 2024

jbudz commented May 2, 2024

kibana-ci commented May 2, 2024

ESLint disabled line counts

Total ESLint disabled count

kibanamachine commented May 2, 2024

azasypkin May 3, 2024 •

edited

Loading

[Security Solution] Fix assistant settings availability for non-superuser role #182322

[Security Solution] Fix assistant settings availability for non-superuser role #182322

Conversation

YulNaumenko commented May 2, 2024 • edited by kibanamachine Loading

semd commented May 2, 2024 • edited Loading

semd left a comment

Choose a reason for hiding this comment

CoenWarmer left a comment

Choose a reason for hiding this comment

kdelemme left a comment

Choose a reason for hiding this comment

azasypkin left a comment

Choose a reason for hiding this comment

azasypkin May 2, 2024

Choose a reason for hiding this comment

azasypkin May 2, 2024

Choose a reason for hiding this comment

jbudz commented May 2, 2024

kibana-ci commented May 2, 2024

💚 Build Succeeded

Metrics [docs]

Page load bundle

Saved Objects .kibana field count

ESLint disabled line counts

Total ESLint disabled count

History

kibanamachine commented May 2, 2024

💚 All backports created successfully

Questions ?

azasypkin May 3, 2024 • edited Loading

Choose a reason for hiding this comment

YulNaumenko commented May 2, 2024 •

edited by kibanamachine

Loading

semd commented May 2, 2024 •

edited

Loading

azasypkin May 3, 2024 •

edited

Loading