[ES|QL] Rename the setting to a more generic one and move to the general section #182074

stratoula · 2024-04-30T06:54:55Z

Summary

Renames the setting from discover:enableESQL to enableESQL and moves it to the General Section

We checked the telemetry and a very small percentage of users have switched off this setting. It was also on tech preview so we decided in favor of this change as more and more applications are using this setting to hide ESQL from their applications.

Release note

We renamed the advanced setting which hides the ES|QL from the UI from discover:enableESQL to enableESQL. You have to switch it off again if you want to disable ES|QL features from your kibana applications.

github-actions · 2024-04-30T06:55:09Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

…fix'

x-pack/plugins/index_management/server/test/helpers/route_dependencies.ts

elasticmachine · 2024-04-30T11:42:57Z

Pinging @elastic/kibana-esql (Team:ESQL)

ymao1

response ops changes LGTM

tonyghiani

logs_explorer changes LGTM

jgowdyelastic

ML changes LGTM

stratoula · 2024-05-01T12:55:20Z

/ci

kibana-ci · 2024-05-01T13:49:55Z

💚 Build Succeeded

Buildkite Build
Commit: 5db7c80
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-182074-5db7c80c9359
Observability Deployment

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`dataVisualizer`	669	651	-18
`ml`	2033	2014	-19
total			-37

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/discover-utils`	82	81	-1
`@kbn/esql-utils`	22	23	+1
total			-0

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dataVisualizer`	658.4KB	658.5KB	+136.0B
`discover`	637.2KB	637.2KB	+22.0B
`lens`	1.4MB	1.4MB	+101.0B
`logsExplorer`	317.9KB	317.9KB	-9.0B
`ml`	4.2MB	4.2MB	+4.0B
`stackAlerts`	82.3KB	82.3KB	-9.0B
total			+245.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id	before	after	diff
`module count`	-	5887	+5887
`total size`	-	6.7MB	+6.7MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`discover`	35.0KB	35.1KB	+84.0B
`ml`	77.2KB	77.2KB	+40.0B
total			+124.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/discover-utils`	110	109	-1
`@kbn/esql-utils`	24	25	+1
total			-0

History

💚 Build #206850 succeeded be6697b
💔 Build #206830 failed 8b1502e
💔 Build #206809 failed f076848
💔 Build #206791 failed 87b93a5
💔 Build #206789 failed 916f79c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

markov00

Code review, changes looks ok with no major issues.

markov00 · 2024-05-01T13:58:32Z

x-pack/plugins/stack_alerts/public/rule_types/es_query/expression/query_form_type_chooser.tsx

@@ -50,7 +50,7 @@ export const QueryFormTypeChooser: React.FC<QueryFormTypeProps> = ({
  onFormTypeSelect,
 }) => {
  const { uiSettings } = useTriggerUiActionServices();
-  const isEsqlEnabled = uiSettings?.get('discover:enableESQL');
+  const isEsqlEnabled = uiSettings?.get('enableESQL');


What about using the ENABLE_ESQL constant used also in a previous file for the same code?

kibanamachine · 2024-05-01T14:18:33Z

💔 All backports failed

Status	Branch	Result
❌	8.14	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 182074

Questions ?

Please refer to the Backport tool documentation

stratoula · 2024-05-01T14:45:14Z

💚 All backports created successfully

Status	Branch	Result
✅	8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…ral section (elastic#182074) ## Summary Renames the setting from discover:enableESQL to enableESQL and moves it to the General Section <img width="985" alt="image" src="https://github.com/elastic/kibana/assets/17003240/ebafe7cd-4695-413c-a0e3-90e3574139e5"> We checked the telemetry and a very small percentage of users have switched off this setting. It was also on tech preview so we decided in favor of this change as more and more applications are using this setting to hide ESQL from their applications. <img width="850" alt="image" src="https://github.com/elastic/kibana/assets/17003240/404f2494-8a17-4a9d-943a-d9d72b324bc0"> ### Release note We renamed the advanced setting which hides the ES|QL from the UI from `discover:enableESQL` to `enableESQL`. You have to switch it off again if you want to disable ES|QL features from your kibana applications. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit f3d18fa) # Conflicts: # config/serverless.yml # packages/kbn-management/settings/setting_ids/index.ts # x-pack/plugins/data_visualizer/tsconfig.json # x-pack/plugins/lens/public/trigger_actions/open_lens_config/in_app_embeddable_edit/in_app_embeddable_edit_action_helpers.tsx # x-pack/plugins/ml/tsconfig.json

…he general section (#182074) (#182252) # Backport This will backport the following commits from `main` to `8.14`: - [[ES|QL] Rename the setting to a more generic one and move to the general section (#182074)](#182074)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  --------- Co-authored-by: kibanamachine <[email protected]>

* master: (1654 commits) Bump ejs from 3.1.9 to 3.1.10 Don't render exceptions flyout if data is loading (elastic#181588) Enable value list modal (elastic#181593) skip flaky suite (elastic#181777) skip failing test suite (elastic#182263) [Mappings Editor] Disable _source field in serverless (elastic#181712) [data.search] Fix unhandled promise rejections (elastic#181785) [Fleet] Fix logic for detecting first time Elastic Agent users (elastic#182214) [ML] Decouple data_visualizer from MapEmbeddable (elastic#181928) [ES|QL] Sorting accepts expressions (elastic#181916) [ML] Single Metric Viewer: ensures chart displays correctly when opening from a job annotation (elastic#182176) Adding optional Description field to Roles APIs (elastic#182039) Upgrade Markdown-it to 14.1.0 (elastic#182244) Bump xml-crypto from 5.0.0 to 6.0.0 [DOCS] Fix docs and screenshots for rule creation changes (elastic#181925) Update dependency elastic-apm-node to ^4.5.3 (main) (elastic#182236) [Obs AI Assistant] register alert details context in observability plugin (elastic#181501) Add `@typescript-eslint/no-floating-promises` (elastic#181456) [Playground] Propagate Error message into FE (elastic#182201) [ES|QL] Rename the setting to a more generic one and move to the general section (elastic#182074) ...

## Summary Follow up to this PR: #181616 Renaming `discover:enableEsql` to `enableESQL` according to this change: #182074

stratoula added 2 commits April 30, 2024 08:20

[ES|QL] Move setting from Discover to the General section

cc034ee

Move the setting to the General settings and rename it to enableESQL

916f79c

stratoula changed the title ~~Rename setting esql~~ [ES|QL] Rename the setting to a more generic one and move to the general section Apr 30, 2024

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

87b93a5

…fix'

stratoula mentioned this pull request Apr 30, 2024

[Security Solution] - Security solution ES|QL configurable via advanced setting #181616

Merged

Fix broken type

f076848

stratoula commented Apr 30, 2024

View reviewed changes

x-pack/plugins/index_management/server/test/helpers/route_dependencies.ts Outdated Show resolved Hide resolved

stratoula added 2 commits April 30, 2024 11:06

Merge branch 'main' into rename-setting-esql

8b1502e

Merge branch 'main' into rename-setting-esql

be6697b

stratoula added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.14.0 v8.15.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana release_note:breaking labels Apr 30, 2024

stratoula marked this pull request as ready for review April 30, 2024 11:42

stratoula requested review from a team as code owners April 30, 2024 11:42

pgayvallet approved these changes Apr 30, 2024

View reviewed changes

botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels Apr 30, 2024

ymao1 approved these changes Apr 30, 2024

View reviewed changes

tonyghiani approved these changes Apr 30, 2024

View reviewed changes

sabarasaba approved these changes Apr 30, 2024

View reviewed changes

drewdaemon approved these changes Apr 30, 2024

View reviewed changes

jgowdyelastic approved these changes May 1, 2024

View reviewed changes

Dosant approved these changes May 1, 2024

View reviewed changes

dgieselaar approved these changes May 1, 2024

View reviewed changes

Merge branch 'main' into rename-setting-esql

5db7c80

markov00 approved these changes May 1, 2024

View reviewed changes

stratoula merged commit f3d18fa into elastic:main May 1, 2024
18 checks passed

stratoula mentioned this pull request May 1, 2024

[8.14] [ES|QL] Rename the setting to a more generic one and move to the general section (#182074) #182252

Merged

michaelolo24 mentioned this pull request May 2, 2024

[Security Solution] - Rename esql setting #182432

Merged

jbudz pushed a commit that referenced this pull request May 2, 2024

[Security Solution] - Rename esql setting (#182432)

c053208

## Summary Follow up to this PR: #181616 Renaming `discover:enableEsql` to `enableESQL` according to this change: #182074

szaffarano mentioned this pull request Jul 12, 2024

[8.14] [Telemetry][Security Solution] Use the proper index to query builtin alerts (#187859) #188233

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ES|QL] Rename the setting to a more generic one and move to the general section #182074

[ES|QL] Rename the setting to a more generic one and move to the general section #182074

stratoula commented Apr 30, 2024 •

edited by kibanamachine

Loading

github-actions bot commented Apr 30, 2024

elasticmachine commented Apr 30, 2024

ymao1 left a comment

tonyghiani left a comment

jgowdyelastic left a comment

stratoula commented May 1, 2024

kibana-ci commented May 1, 2024 •

edited

Loading

API count

markov00 left a comment

markov00 May 1, 2024

kibanamachine commented May 1, 2024

stratoula commented May 1, 2024

[ES|QL] Rename the setting to a more generic one and move to the general section #182074

[ES|QL] Rename the setting to a more generic one and move to the general section #182074

Conversation

stratoula commented Apr 30, 2024 • edited by kibanamachine Loading

Summary

Release note

github-actions bot commented Apr 30, 2024

elasticmachine commented Apr 30, 2024

ymao1 left a comment

Choose a reason for hiding this comment

tonyghiani left a comment

Choose a reason for hiding this comment

jgowdyelastic left a comment

Choose a reason for hiding this comment

stratoula commented May 1, 2024

kibana-ci commented May 1, 2024 • edited Loading

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Canvas Sharable Runtime

Page load bundle

API count

History

markov00 left a comment

Choose a reason for hiding this comment

markov00 May 1, 2024

Choose a reason for hiding this comment

kibanamachine commented May 1, 2024

💔 All backports failed

Manual backport

Questions ?

stratoula commented May 1, 2024

💚 All backports created successfully

Questions ?

stratoula commented Apr 30, 2024 •

edited by kibanamachine

Loading

kibana-ci commented May 1, 2024 •

edited

Loading