[User Profile] Clean up specific usage of deprecated toMountPoint utility #180003

tsullivan · 2024-04-03T22:21:46Z

Summary

Partially addresses https://github.com/elastic/kibana-team/issues/805

This change assumes that achieving dark mode consistency would be easier if we remove the deprecated utilities that allow consumers to get away with dark mode bugs. These changes address a specific usage of the deprecated toMountPoint utility in the User-Profile package that has spread itself to a few places.

Checklist

Unit or functional tests were updated or added to match the most common scenarios
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

…d util

…fix'

tsullivan · 2024-04-04T03:20:42Z

src/plugins/embeddable/public/react_embeddable_system/react_embeddable_renderer.tsx

@@ -14,8 +14,7 @@ import {
 import { PresentationPanel, PresentationPanelProps } from '@kbn/presentation-panel-plugin/public';
 import { ComparatorDefinition, StateComparators } from '@kbn/presentation-publishing';
 import React, { useEffect, useImperativeHandle, useMemo, useRef } from 'react';
-import { combineLatest } from 'rxjs';
-import { debounceTime, skip } from 'rxjs/operators';
+import { combineLatest, debounceTime, skip } from 'rxjs';


Maybe I rebased main at a strange time. Otherwise, I have no idea why this came up as a lint issue and caused a failure in my PR :/

That's the reason #179553 😊

Thanks for fixing this @tsullivan!

kibana-ci · 2024-04-04T04:07:46Z

💚 Build Succeeded

Buildkite Build
Commit: ac1d658

The CI Stats report is too large to be displayed here, check out the CI build annotation for this information.

History

💔 Build #200989 failed 9701885
💔 Build #200984 failed 247ff6098e5f3e2d37294061f7a67d180678e7c5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

azasypkin

LGTM, thanks!

jloleysens

Nice work @tsullivan !

ThomThomson · 2024-04-04T14:00:50Z

src/plugins/embeddable/public/react_embeddable_system/react_embeddable_renderer.tsx

@@ -14,8 +14,7 @@ import {
 import { PresentationPanel, PresentationPanelProps } from '@kbn/presentation-panel-plugin/public';
 import { ComparatorDefinition, StateComparators } from '@kbn/presentation-publishing';
 import React, { useEffect, useImperativeHandle, useMemo, useRef } from 'react';
-import { combineLatest } from 'rxjs';
-import { debounceTime, skip } from 'rxjs/operators';
+import { combineLatest, debounceTime, skip } from 'rxjs';


Thanks for fixing this @tsullivan!

…180098) ## Summary Partially addresses elastic/kibana-team#805 Follows #180003 These changes come up from searching in the code and finding where certain kinds of deprecated AppEx-SharedUX modules are imported. **Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.** * Started with focusing on code owned by ResponseOps. * Stack Management changes trickled into this PR because ResponseOps needs the `theme` field from `ManagementAppMountParams` * Security changes trickled into this PR, in its test code, because of the Stack Management changes. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <[email protected]>

## Summary Partially addresses elastic/kibana-team#805 Follows #180003 These changes come up from searching in the code and finding where certain kinds of deprecated AppEx-SharedUX modules are imported. **Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.** This focuses on code owned by the Logstash team. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

…80515) ## Summary Partially addresses elastic/kibana-team#805 Follows #180003 These changes come up from searching in the code and finding where certain kinds of deprecated AppEx-SharedUX modules are imported. **Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.** This focuses on code within Platform Onboarding. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

…es (#180331) ## Summary Partially addresses elastic/kibana-team#805 Follows #180003 These changes come up from searching in the code and finding where certain kinds of deprecated AppEx-SharedUX modules are imported. **Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.** This focuses on code within Stack Management. <img width="1107" alt="image" src="https://github.com/elastic/kibana/assets/908371/c0d2ce08-ac35-45a7-8192-0b2256fceb0e"> ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <[email protected]>

) ## Summary Partially addresses elastic/kibana-team#805 Follows #180003 These changes come up from searching in the code and finding where certain kinds of deprecated AppEx-SharedUX modules are imported. **Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.** This focuses on code within AppEx-SharedUX. [Reporting changes are separate](https://github.com/elastic/kibana/pull/). <img width="1107" alt="image" src="https://github.com/elastic/kibana/assets/908371/c0d2ce08-ac35-45a7-8192-0b2256fceb0e"> ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

…ct rendering utilities (#180844) ## Summary Partially addresses elastic/kibana-team#805 Follows #180003 These changes come up from searching in the code and finding where certain kinds of deprecated AppEx-SharedUX modules are imported. **Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.** This focuses on code within Observability User Experience: Infrastructure and Services. <img width="1196" alt="image" src="https://github.com/elastic/kibana/assets/908371/7f8d3707-94f0-4746-8dd5-dd858ce027f9"> ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <[email protected]>

) ## Summary Partially addresses elastic/kibana-team#805 Follows #180003 These changes come up from searching in the code and finding where certain kinds of deprecated AppEx-SharedUX modules are imported. **Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.** This focuses on code within Security. <img width="1107" alt="image" src="https://github.com/elastic/kibana/assets/908371/c0d2ce08-ac35-45a7-8192-0b2256fceb0e"> Note: this also makes inclusion of `i18n` and `analytics` dependencies consistent. Analytics is an optional dependency for the SharedUX modules, which wrap `KibanaErrorBoundaryProvider` and is designed to capture telemetry about errors that are caught in the error boundary. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <[email protected]>

elastic deleted a comment from kibana-ci Apr 3, 2024

tsullivan and others added 5 commits April 3, 2024 18:46

[User Profile] Clean up a particularly complicated usage of deprecate…

de237d9

…d util

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

6786dd5

…fix'

fix requiredBundles which longer use kibanaReact

07009b2

clean up instance of deprecated KibanaThemeProvider

ea36216

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

9701885

…fix'

tsullivan force-pushed the sharedux/cleanup-tomountpoint-deprecations-i branch from 25b956b to 9701885 Compare April 4, 2024 01:47

Mashalm-12 mentioned this pull request Apr 4, 2024

1 #180006

Closed

fix a lint

ac1d658

tsullivan commented Apr 4, 2024

View reviewed changes

tsullivan marked this pull request as ready for review April 4, 2024 04:43

tsullivan requested review from a team as code owners April 4, 2024 04:43

tsullivan added release_note:skip Skip the PR/issue when compiling release notes technical debt Improvement of the software architecture and operational architecture labels Apr 4, 2024

botelastic bot added the Feature:Embedding Embedding content via iFrame label Apr 4, 2024

sebelga approved these changes Apr 4, 2024

View reviewed changes

azasypkin approved these changes Apr 4, 2024

View reviewed changes

jloleysens approved these changes Apr 4, 2024

View reviewed changes

ThomThomson approved these changes Apr 4, 2024

View reviewed changes

tsullivan merged commit 0e422f9 into elastic:main Apr 4, 2024
23 checks passed

kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Apr 4, 2024

This was referenced Apr 4, 2024

[EuiProvider/ResponseOps] Remove usage of deprecated React rendering utilities #180098

Merged

[EuiProvider/Stack Management] Remove usage of deprecated React rendering utilities #180331

Merged

tsullivan mentioned this pull request Apr 10, 2024

[Logstash] Remove usage of deprecated SharedUX utils #180512

Merged

3 tasks

tsullivan mentioned this pull request Apr 13, 2024

[EuiProvider/Reporting] Remove usage of deprecated React rendering utilities #180759

Merged

3 tasks

tsullivan mentioned this pull request Apr 15, 2024

[EuiProvider/Oblt UX: Infrastructure and Services] Remove usage of deprecated React rendering utilities #180844

Merged

3 tasks

tsullivan deleted the sharedux/cleanup-tomountpoint-deprecations-i branch April 30, 2024 21:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[User Profile] Clean up specific usage of deprecated toMountPoint utility #180003

[User Profile] Clean up specific usage of deprecated toMountPoint utility #180003

tsullivan commented Apr 3, 2024 •

edited

Loading

tsullivan Apr 4, 2024

sebelga Apr 4, 2024

ThomThomson Apr 4, 2024

kibana-ci commented Apr 4, 2024

azasypkin left a comment

jloleysens left a comment

ThomThomson Apr 4, 2024

[User Profile] Clean up specific usage of deprecated toMountPoint utility #180003

[User Profile] Clean up specific usage of deprecated toMountPoint utility #180003

Conversation

tsullivan commented Apr 3, 2024 • edited Loading

Summary

Checklist

tsullivan Apr 4, 2024

Choose a reason for hiding this comment

sebelga Apr 4, 2024

Choose a reason for hiding this comment

ThomThomson Apr 4, 2024

Choose a reason for hiding this comment

kibana-ci commented Apr 4, 2024

💚 Build Succeeded

History

azasypkin left a comment

Choose a reason for hiding this comment

jloleysens left a comment

Choose a reason for hiding this comment

ThomThomson Apr 4, 2024

Choose a reason for hiding this comment

tsullivan commented Apr 3, 2024 •

edited

Loading