Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiProvider/Security] Remove usage of deprecated React rendering utilities #180517

Merged

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Apr 10, 2024

Summary

Partially addresses https://github.com/elastic/kibana-team/issues/805

Follows #180003

These changes come up from searching in the code and finding where certain kinds of deprecated AppEx-SharedUX modules are imported. Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.

This focuses on code within Security.

image

Note: this also makes inclusion of i18n and analytics dependencies consistent. Analytics is an optional dependency for the SharedUX modules, which wrap KibanaErrorBoundaryProvider and is designed to capture telemetry about errors that are caught in the error boundary.

Checklist

Delete any items that are not applicable to this PR.

@tsullivan tsullivan force-pushed the sharedux/cleanup-tomountpoint-deprecations-iiid branch 2 times, most recently from 094dda2 to 7f3d6c4 Compare April 10, 2024 18:07
@tsullivan tsullivan added the release_note:skip Skip the PR/issue when compiling release notes label Apr 10, 2024
@tsullivan tsullivan force-pushed the sharedux/cleanup-tomountpoint-deprecations-iiid branch 5 times, most recently from f610205 to c3cddb6 Compare April 12, 2024 16:51
@tsullivan tsullivan force-pushed the sharedux/cleanup-tomountpoint-deprecations-iiid branch from c3cddb6 to e5163e4 Compare April 12, 2024 19:26
@tsullivan tsullivan marked this pull request as ready for review April 15, 2024 14:26
@tsullivan tsullivan requested a review from a team as a code owner April 15, 2024 14:26
@tsullivan tsullivan added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Apr 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
interactiveSetup 62 57 -5
security 525 519 -6
spaces 258 268 +10
total -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
security 199 200 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
security 585.0KB 584.5KB -512.0B
spaces 175.1KB 175.1KB -64.0B
total -576.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
interactiveSetup 60.8KB 58.7KB -2.2KB
security 70.7KB 67.5KB -3.2KB
spaces 24.6KB 25.6KB +1.0KB
total -4.3KB
Unknown metric groups

API count

id before after diff
security 409 410 +1

References to deprecated APIs

id before after diff
security 70 37 -33
spaces 23 13 -10
total -43

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit ef5af17 into elastic:main Apr 18, 2024
17 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 18, 2024
@tsullivan tsullivan deleted the sharedux/cleanup-tomountpoint-deprecations-iiid branch April 30, 2024 21:42
@tsullivan tsullivan changed the title [Security] Remove usage of deprecated React rendering utilities [EuiProvider/Security] Remove usage of deprecated React rendering utilities Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants