-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiProvider/Reporting] Remove usage of deprecated React rendering utilities #180759
Merged
tsullivan
merged 6 commits into
elastic:main
from
tsullivan:sharedux/cleanup-tomountpoint-deprecations-iiig
Apr 25, 2024
Merged
[EuiProvider/Reporting] Remove usage of deprecated React rendering utilities #180759
tsullivan
merged 6 commits into
elastic:main
from
tsullivan:sharedux/cleanup-tomountpoint-deprecations-iiig
Apr 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
sharedux/cleanup-tomountpoint-deprecations-iiig
branch
3 times, most recently
from
April 17, 2024 05:09
455246b
to
aaf45dd
Compare
tsullivan
added
technical debt
Improvement of the software architecture and operational architecture
release_note:skip
Skip the PR/issue when compiling release notes
labels
Apr 24, 2024
tsullivan
force-pushed
the
sharedux/cleanup-tomountpoint-deprecations-iiig
branch
3 times, most recently
from
April 24, 2024 22:33
4c2e5e6
to
83bfbb2
Compare
tsullivan
force-pushed
the
sharedux/cleanup-tomountpoint-deprecations-iiig
branch
from
April 24, 2024 22:45
83bfbb2
to
64ba840
Compare
/ci |
tsullivan
added
the
Team:SharedUX
Team label for AppEx-SharedUX (formerly Global Experience)
label
Apr 25, 2024
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Dosant
approved these changes
Apr 25, 2024
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.15.0
backport:skip
This commit does not require backporting
labels
Apr 25, 2024
tsullivan
changed the title
[Reporting] Remove usage of deprecated React rendering utilities
[EuiProvider/Reporting] Remove usage of deprecated React rendering utilities
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:SharedUX
Team label for AppEx-SharedUX (formerly Global Experience)
technical debt
Improvement of the software architecture and operational architecture
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses https://github.com/elastic/kibana-team/issues/805
Follows #180516
These changes come up from searching in the code and finding where certain kinds of deprecated AppEx-SharedUX modules are imported. Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.
This focuses on code within Reporting.
Note: this also makes inclusion of
i18n
andanalytics
dependencies consistent. Analytics is an optional dependency for the SharedUX modules, which wrapKibanaErrorBoundaryProvider
and is designed to capture telemetry about errors that are caught in the error boundary.Checklist
Delete any items that are not applicable to this PR.