Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiProvider/Reporting] Remove usage of deprecated React rendering utilities #180759

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Apr 13, 2024

Summary

Partially addresses https://github.com/elastic/kibana-team/issues/805

Follows #180516

These changes come up from searching in the code and finding where certain kinds of deprecated AppEx-SharedUX modules are imported. Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.

This focuses on code within Reporting.

image

Note: this also makes inclusion of i18n and analytics dependencies consistent. Analytics is an optional dependency for the SharedUX modules, which wrap KibanaErrorBoundaryProvider and is designed to capture telemetry about errors that are caught in the error boundary.

Checklist

Delete any items that are not applicable to this PR.

@tsullivan tsullivan force-pushed the sharedux/cleanup-tomountpoint-deprecations-iiig branch 3 times, most recently from 455246b to aaf45dd Compare April 17, 2024 05:09
@tsullivan tsullivan added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes labels Apr 24, 2024
@tsullivan tsullivan force-pushed the sharedux/cleanup-tomountpoint-deprecations-iiig branch 3 times, most recently from 4c2e5e6 to 83bfbb2 Compare April 24, 2024 22:33
@tsullivan tsullivan force-pushed the sharedux/cleanup-tomountpoint-deprecations-iiig branch from 83bfbb2 to 64ba840 Compare April 24, 2024 22:45
@tsullivan
Copy link
Member Author

/ci

@tsullivan tsullivan marked this pull request as ready for review April 25, 2024 13:36
@tsullivan tsullivan requested a review from a team as a code owner April 25, 2024 13:36
@tsullivan tsullivan added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Apr 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@tsullivan tsullivan enabled auto-merge (squash) April 25, 2024 14:55
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
reporting 125 119 -6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
reporting 71.1KB 68.6KB -2.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
reporting 56.0KB 55.2KB -764.0B
Unknown metric groups

References to deprecated APIs

id before after diff
@kbn/reporting-public 2 0 -2
reporting 35 17 -18
total -20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit 15c6a36 into elastic:main Apr 25, 2024
17 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Apr 25, 2024
@tsullivan tsullivan deleted the sharedux/cleanup-tomountpoint-deprecations-iiig branch April 30, 2024 21:42
@tsullivan tsullivan changed the title [Reporting] Remove usage of deprecated React rendering utilities [EuiProvider/Reporting] Remove usage of deprecated React rendering utilities Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) technical debt Improvement of the software architecture and operational architecture v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants