[SLO] Fix bug with 'View events' feature to filter on group-by fields #178260
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
simianhacker
added
release_note:skip
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
There was a problem hiding this comment.
I somehow managed to navigate to the the parent SLO details page for an SLO with a group by (no instanceId in the URL state). I'm not sure how I managed to do that, but when clicking on the events, I ended up with this error. Is this something we want to account for.
…detail page (no-data usecase)
|
@dominiqueclarke You probably clicked on the SLO detail page when the SLO definition was in the |
…o-bug-fix-for-view-events
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
| alias: i18n.translate('xpack.observability.slo.sloDetails.totalFilterLabel', { | ||
| defaultMessage: 'Total events', | ||
| }), | ||
| value: JSON.stringify(customBadFilter), |
There was a problem hiding this comment.
Why is the customBadFilter the value here?
## Summary This PR is a follow up to #178260, when we added the "Total events" filter we forgot to update the value's text representation of the `customTotalFilter`.
Summary
This PR fixes #178231 by adding filters for the group by values. This also fixes a bug where the Discover time picker was missing due to the incompatible data view ID.
Testing
You should see filters for each of the group bys along with disabled filters for "Good events" and "Bad events"