Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLO] View events on SLO Detail Page should include filter for the group by fields #178231

Closed
simianhacker opened this issue Mar 7, 2024 · 1 comment · Fixed by #178260
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:SLO Team:obs-ux-management Observability Management User Experience Team

Comments

@simianhacker
Copy link
Member

Kibana version:
main

Describe the bug:
When you click on the "View event" link on the "Good vs Bad" events chart on the SLO detail page, it doesn't include the filter for the group by fields for the SLO instance.

Steps to reproduce:

  1. Create a KQL SLO for the Admin Console using fake_stack from kbn-data-forge and group by url.domain
  2. Visit the SLO detail page for an instance
  3. Click "View events" on the "Good vs. Bad" chart
  4. The group by filter is missing

Expected behavior:

It should filter by the instance id OR group by fields.

@simianhacker simianhacker added bug Fixes for quality problems that affect the customer experience Feature:SLO Team:obs-ux-management Observability Management User Experience Team labels Mar 7, 2024
@simianhacker simianhacker self-assigned this Mar 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

simianhacker added a commit that referenced this issue Mar 12, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…#178260)

## Summary

This PR fixes #178231 by adding filters for the group by values. This
also fixes a bug where the Discover time picker was missing due to the
incompatible data view ID.

### Testing

1. Create an SLO (Custom KQL) with a group by (or multiple)
2. Visit the SLO detail page
3. Click on the "View events" 

You should see filters for each of the group bys along with disabled
filters for "Good events" and "Bad events"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:SLO Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants