Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLO] Fixing a missed variable in the discover filter #178502

Merged
merged 1 commit into from
Mar 12, 2024
Merged

[SLO] Fixing a missed variable in the discover filter #178502

merged 1 commit into from
Mar 12, 2024

Conversation

simianhacker
Copy link
Member

Summary

This PR is a follow up to #178260, when we added the "Total events" filter we forgot to update the value's text representation of the customTotalFilter.

@simianhacker simianhacker added release_note:skip Skip the PR/issue when compiling release notes Feature:SLO Team:obs-ux-management Observability Management User Experience Team v8.14.0 labels Mar 12, 2024
@simianhacker simianhacker requested a review from a team as a code owner March 12, 2024 13:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@simianhacker simianhacker enabled auto-merge (squash) March 12, 2024 13:52
dominiqueclarke
dominiqueclarke approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker merged commit 834371e into elastic:main Mar 12, 2024
26 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 12, 2024
@simianhacker simianhacker deleted the fix-total-event-filter branch April 17, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:SLO release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@simianhacker @elasticmachine @apmmachine @kibana-ci @dominiqueclarke @kibanamachine