[Fleet] Fix inactive popover tour not resetting #176929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criamico
added
release_note:fix
Team:Fleet
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Pinging @elastic/fleet (Team:Fleet) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @criamico |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 19, 2024
Fixes elastic#176124 ## Summary The [inactive popover](elastic#149226) that appears the first time after agents become inactive was broken (probably because of a EUi upgrade) and wasn't dismissable anymore. I'm adding a footer with button that makes it easily dismissable.  ### Testing - In dev tools console, run the following. This removes from the local storage the key that signals that the tour was already ran once. ``` localStorage.removeItem("fleet.inactiveAgentsCalloutHasBeenDismissed") ``` - Enroll some agents and wait that at least one becomes inactive - The popover should be visible and it should be possible to dismiss it by clicking "got it". Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 851657c)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
criamico
added a commit
to criamico/kibana
that referenced
this pull request
Feb 19, 2024
Fixes elastic#176124 ## Summary The [inactive popover](elastic#149226) that appears the first time after agents become inactive was broken (probably because of a EUi upgrade) and wasn't dismissable anymore. I'm adding a footer with button that makes it easily dismissable.  ### Testing - In dev tools console, run the following. This removes from the local storage the key that signals that the tour was already ran once. ``` localStorage.removeItem("fleet.inactiveAgentsCalloutHasBeenDismissed") ``` - Enroll some agents and wait that at least one becomes inactive - The popover should be visible and it should be possible to dismiss it by clicking "got it". Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 851657c) # Conflicts: # x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_status_filter.tsx
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
criamico
added a commit
that referenced
this pull request
Feb 20, 2024
…7172) # Backport This will backport the following commits from `main` to `8.12`: - [[Fleet] Fix inactive popover tour not resetting (#176929)](#176929) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cristina Amico","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-19T10:25:20Z","message":"[Fleet] Fix inactive popover tour not resetting (#176929)\n\nFixes https://github.com/elastic/kibana/issues/176124\r\n\r\n## Summary\r\nThe [inactive popover](https://github.com/elastic/kibana/pull/149226)\r\nthat appears the first time after agents become inactive was broken\r\n(probably because of a EUi upgrade) and wasn't dismissable anymore.\r\n\r\nI'm adding a footer with button that makes it easily dismissable.\r\n\r\n\r\n\r\n### Testing \r\n- In dev tools console, run the following. This removes from the local\r\nstorage the key that signals that the tour was already ran once.\r\n```\r\n localStorage.removeItem(\"fleet.inactiveAgentsCalloutHasBeenDismissed\")\r\n```\r\n- Enroll some agents and wait that at least one becomes inactive\r\n- The popover should be visible and it should be possible to dismiss it\r\nby clicking \"got it\".\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"851657c6f9fd0113f3a5900c100ce0f3e151841f","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","v8.13.0","v8.12.2","v8.14.0"],"number":176929,"url":"https://github.com/elastic/kibana/pull/176929","mergeCommit":{"message":"[Fleet] Fix inactive popover tour not resetting (#176929)\n\nFixes https://github.com/elastic/kibana/issues/176124\r\n\r\n## Summary\r\nThe [inactive popover](https://github.com/elastic/kibana/pull/149226)\r\nthat appears the first time after agents become inactive was broken\r\n(probably because of a EUi upgrade) and wasn't dismissable anymore.\r\n\r\nI'm adding a footer with button that makes it easily dismissable.\r\n\r\n\r\n\r\n### Testing \r\n- In dev tools console, run the following. This removes from the local\r\nstorage the key that signals that the tour was already ran once.\r\n```\r\n localStorage.removeItem(\"fleet.inactiveAgentsCalloutHasBeenDismissed\")\r\n```\r\n- Enroll some agents and wait that at least one becomes inactive\r\n- The popover should be visible and it should be possible to dismiss it\r\nby clicking \"got it\".\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"851657c6f9fd0113f3a5900c100ce0f3e151841f"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/177161","number":177161,"state":"OPEN"},{"branch":"8.12","label":"v8.12.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176929","number":176929,"mergeCommit":{"message":"[Fleet] Fix inactive popover tour not resetting (#176929)\n\nFixes https://github.com/elastic/kibana/issues/176124\r\n\r\n## Summary\r\nThe [inactive popover](https://github.com/elastic/kibana/pull/149226)\r\nthat appears the first time after agents become inactive was broken\r\n(probably because of a EUi upgrade) and wasn't dismissable anymore.\r\n\r\nI'm adding a footer with button that makes it easily dismissable.\r\n\r\n\r\n\r\n### Testing \r\n- In dev tools console, run the following. This removes from the local\r\nstorage the key that signals that the tour was already ran once.\r\n```\r\n localStorage.removeItem(\"fleet.inactiveAgentsCalloutHasBeenDismissed\")\r\n```\r\n- Enroll some agents and wait that at least one becomes inactive\r\n- The popover should be visible and it should be possible to dismiss it\r\nby clicking \"got it\".\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"851657c6f9fd0113f3a5900c100ce0f3e151841f"}}]}] BACKPORT-->
kibanamachine
added a commit
that referenced
this pull request
Feb 21, 2024
…7161) # Backport This will backport the following commits from `main` to `8.13`: - [[Fleet] Fix inactive popover tour not resetting (#176929)](#176929) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cristina Amico","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-19T10:25:20Z","message":"[Fleet] Fix inactive popover tour not resetting (#176929)\n\nFixes https://github.com/elastic/kibana/issues/176124\r\n\r\n## Summary\r\nThe [inactive popover](https://github.com/elastic/kibana/pull/149226)\r\nthat appears the first time after agents become inactive was broken\r\n(probably because of a EUi upgrade) and wasn't dismissable anymore.\r\n\r\nI'm adding a footer with button that makes it easily dismissable.\r\n\r\n\r\n\r\n### Testing \r\n- In dev tools console, run the following. This removes from the local\r\nstorage the key that signals that the tour was already ran once.\r\n```\r\n localStorage.removeItem(\"fleet.inactiveAgentsCalloutHasBeenDismissed\")\r\n```\r\n- Enroll some agents and wait that at least one becomes inactive\r\n- The popover should be visible and it should be possible to dismiss it\r\nby clicking \"got it\".\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"851657c6f9fd0113f3a5900c100ce0f3e151841f","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","v8.13.0","v8.12.2","v8.14.0"],"title":"[Fleet] Fix inactive popover tour not resetting","number":176929,"url":"https://github.com/elastic/kibana/pull/176929","mergeCommit":{"message":"[Fleet] Fix inactive popover tour not resetting (#176929)\n\nFixes https://github.com/elastic/kibana/issues/176124\r\n\r\n## Summary\r\nThe [inactive popover](https://github.com/elastic/kibana/pull/149226)\r\nthat appears the first time after agents become inactive was broken\r\n(probably because of a EUi upgrade) and wasn't dismissable anymore.\r\n\r\nI'm adding a footer with button that makes it easily dismissable.\r\n\r\n\r\n\r\n### Testing \r\n- In dev tools console, run the following. This removes from the local\r\nstorage the key that signals that the tour was already ran once.\r\n```\r\n localStorage.removeItem(\"fleet.inactiveAgentsCalloutHasBeenDismissed\")\r\n```\r\n- Enroll some agents and wait that at least one becomes inactive\r\n- The popover should be visible and it should be possible to dismiss it\r\nby clicking \"got it\".\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"851657c6f9fd0113f3a5900c100ce0f3e151841f"}},"sourceBranch":"main","suggestedTargetBranches":["8.13","8.12"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.12","label":"v8.12.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176929","number":176929,"mergeCommit":{"message":"[Fleet] Fix inactive popover tour not resetting (#176929)\n\nFixes https://github.com/elastic/kibana/issues/176124\r\n\r\n## Summary\r\nThe [inactive popover](https://github.com/elastic/kibana/pull/149226)\r\nthat appears the first time after agents become inactive was broken\r\n(probably because of a EUi upgrade) and wasn't dismissable anymore.\r\n\r\nI'm adding a footer with button that makes it easily dismissable.\r\n\r\n\r\n\r\n### Testing \r\n- In dev tools console, run the following. This removes from the local\r\nstorage the key that signals that the tour was already ran once.\r\n```\r\n localStorage.removeItem(\"fleet.inactiveAgentsCalloutHasBeenDismissed\")\r\n```\r\n- Enroll some agents and wait that at least one becomes inactive\r\n- The popover should be visible and it should be possible to dismiss it\r\nby clicking \"got it\".\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"851657c6f9fd0113f3a5900c100ce0f3e151841f"}}]}] BACKPORT--> Co-authored-by: Cristina Amico <[email protected]> Co-authored-by: Julia Bardi <[email protected]>
|
This PR didn't landed on time to be included on v8.12.2. Updating the labels. |
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
Fixes elastic#176124 ## Summary The [inactive popover](elastic#149226) that appears the first time after agents become inactive was broken (probably because of a EUi upgrade) and wasn't dismissable anymore. I'm adding a footer with button that makes it easily dismissable.  ### Testing - In dev tools console, run the following. This removes from the local storage the key that signals that the tour was already ran once. ``` localStorage.removeItem("fleet.inactiveAgentsCalloutHasBeenDismissed") ``` - Enroll some agents and wait that at least one becomes inactive - The popover should be visible and it should be possible to dismiss it by clicking "got it". Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176124
Summary
The inactive popover that appears the first time after agents become inactive was broken (probably because of a EUi upgrade) and wasn't dismissable anymore.
I'm adding a footer with button that makes it easily dismissable.
Testing