[8.12] [Fleet] Fix inactive popover tour not resetting (#176929) #177172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes elastic#176124 ## Summary The [inactive popover](elastic#149226) that appears the first time after agents become inactive was broken (probably because of a EUi upgrade) and wasn't dismissable anymore. I'm adding a footer with button that makes it easily dismissable.  ### Testing - In dev tools console, run the following. This removes from the local storage the key that signals that the tour was already ran once. ``` localStorage.removeItem("fleet.inactiveAgentsCalloutHasBeenDismissed") ``` - Enroll some agents and wait that at least one becomes inactive - The popover should be visible and it should be possible to dismiss it by clicking "got it". Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 851657c) # Conflicts: # x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_status_filter.tsx
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
juliaElastic
approved these changes
Feb 20, 2024
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.12:Questions ?
Please refer to the Backport tool documentation