Skip to content

Commit

Permalink
Merge branch 'main' into 176124_fix_inactive_popover
Browse files Browse the repository at this point in the history
  • Loading branch information
kibanamachine authored Feb 15, 2024
2 parents 5a3a5e5 + cec949e commit c5a6d77
Show file tree
Hide file tree
Showing 140 changed files with 15,952 additions and 2,446 deletions.

Large diffs are not rendered by default.

513 changes: 304 additions & 209 deletions docs/developer/architecture/core/saved-objects-service.asciidoc

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ export interface SavedObjectsType<Attributes = any> {
mappings: SavedObjectsTypeMappingDefinition;
/**
* An optional map of {@link SavedObjectMigrationFn | migrations} or a function returning a map of {@link SavedObjectMigrationFn | migrations} to be used to migrate the type.
* @deprecated Use {@link SavedObjectsType.modelVersions | modelVersions} instead.
*/
migrations?: SavedObjectMigrationMap | (() => SavedObjectMigrationMap);
/**
Expand All @@ -78,6 +79,7 @@ export interface SavedObjectsType<Attributes = any> {
* When provided, calls to {@link SavedObjectsClient.create | create} will be validated against this schema.
*
* See {@link SavedObjectsValidationMap} for more details.
* @deprecated Use {@link SavedObjectsType.modelVersions | modelVersions} instead.
*/
schemas?: SavedObjectsValidationMap | (() => SavedObjectsValidationMap);
/**
Expand Down Expand Up @@ -177,7 +179,7 @@ export interface SavedObjectsType<Attributes = any> {
modelVersions?: SavedObjectsModelVersionMap | SavedObjectsModelVersionMapProvider;

/**
* Allows to opt-in to the new model version API.
* Allows to opt-in to the model version API.
*
* Must be a valid semver version (with the patch version being necessarily 0)
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ export function SettingsTab() {
)}
>
<EuiFormRow
style={{ alignSelf: 'end', width: '80%' }}
fullWidth
label={i18n.translate(
'aiAssistantManagementObservability.settingsPage.selectConnectorLabel',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ export const useFetchOccurrencesRange = (params: Params): Result => {
abortSignal: abortControllerRef.current?.signal,
});
} catch (error) {
//
if (error.name !== 'AbortError') {
// eslint-disable-next-line no-console
console.error(error);
}
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => {
await PageObjects.timePicker.setAbsoluteRange(TEST_START_TIME, TEST_END_TIME);
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.unifiedFieldList.waitUntilSidebarHasLoaded();
await PageObjects.unifiedFieldList.toggleSidebarSection('meta');
await PageObjects.unifiedFieldList.openSidebarSection('meta');
});

after(async () => {
Expand Down
7 changes: 5 additions & 2 deletions test/functional/apps/discover/group1/_discover.ts
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});

it('should show matches when time range is expanded', async () => {
await PageObjects.discover.expandTimeRangeAsSuggestedInNoResultsMessage();
await PageObjects.discover.waitUntilSearchingHasFinished();
await retry.waitFor('view all matches to load', async () => {
await PageObjects.discover.expandTimeRangeAsSuggestedInNoResultsMessage();
await PageObjects.discover.waitUntilSearchingHasFinished();
return !(await testSubjects.exists('discoverNoResultsViewAllMatches'));
});
await retry.try(async function () {
expect(await PageObjects.discover.hasNoResults()).to.be(false);
expect(await PageObjects.discover.getHitCountInt()).to.be.above(0);
Expand Down
16 changes: 16 additions & 0 deletions test/functional/page_objects/unified_field_list.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,22 @@ export class UnifiedFieldListPageObject extends FtrService {
);
}

public async openSidebarSection(sectionName: SidebarSectionName) {
const openedSectionSelector = `${this.getSidebarSectionSelector(
sectionName,
true
)}.euiAccordion-isOpen`;

if (await this.find.existsByCssSelector(openedSectionSelector)) {
return;
}

await this.retry.waitFor(`${sectionName} fields section to open`, async () => {
await this.toggleSidebarSection(sectionName);
return await this.find.existsByCssSelector(openedSectionSelector);
});
}

public async waitUntilFieldPopoverIsOpen() {
await this.retry.waitFor('popover is open', async () => {
return Boolean(await this.find.byCssSelector('[data-popover-open="true"]'));
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/actions/jest.integration.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/

module.exports = {
preset: '@kbn/test/jest_integration_node',
preset: '@kbn/test/jest_integration',
rootDir: '../../..',
roots: ['<rootDir>/x-pack/plugins/actions'],
};
Loading

0 comments on commit c5a6d77

Please sign in to comment.