Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Update embed mode test screenshot #174193

Merged
merged 4 commits into from
Jan 4, 2024
Merged

[Dashboard] Update embed mode test screenshot #174193

merged 4 commits into from
Jan 4, 2024

Conversation

Heenawter
Copy link
Contributor

@Heenawter Heenawter commented Jan 3, 2024 •
edited
Loading

Closes #163207

Summary

This PR updates the embed mode baseline screenshot so that the failing test can be unskipped. This test is, unfortunately, very fragile because the font rendering is prone to changing between Chrome updates - however, there isn't really a better way of checking for rendering issues, so we'll have to continue just updating the baseline whenever a failure happens 🙈

Checklist

For maintainers

@Heenawter Heenawter added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes impact:critical This issue should be addressed immediately due to a critical level of impact on the product. backport:skip This commit does not require backporting labels Jan 3, 2024
@Heenawter
Copy link
Contributor Author

/ci

@Heenawter
Copy link
Contributor Author

/ci

@Heenawter Heenawter changed the title [Dashboard] Fix flaky embed mode screenshot test [Dashboard] Update embed mode test screenshots Jan 3, 2024
@Heenawter Heenawter changed the title [Dashboard] Update embed mode test screenshots [Dashboard] Update embed mode test screenshot Jan 3, 2024
@Heenawter
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Heenawter Heenawter marked this pull request as ready for review January 4, 2024 00:04
@Heenawter Heenawter requested a review from a team as a code owner January 4, 2024 00:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

nreese
nreese approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review only

@Heenawter Heenawter merged commit 12f57b3 into elastic:main Jan 4, 2024
20 checks passed
@Heenawter Heenawter deleted the fix-flaky-embed-screenshot_2024-01-03 branch January 4, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture v8.13.0
Projects
None yet
Milestone
No milestone
5 participants
@Heenawter @kibana-ci @elasticmachine @nreese @kibanamachine