Skip to content

Commit

Permalink
[Dashboard] Update embed mode test screenshot (#174193)
Browse files Browse the repository at this point in the history
Closes #163207

## Summary

This PR updates the embed mode baseline screenshot so that the failing
test can be unskipped. This test is, unfortunately, very fragile because
the font rendering is prone to changing between Chrome updates -
however, there isn't really a better way of checking for rendering
issues, so we'll have to continue just updating the baseline whenever a
failure happens 🙈


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed:
- Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4749

![image](https://github.com/elastic/kibana/assets/8698078/eeb87dca-4542-4333-af8b-58d07a8c911e)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
  • Loading branch information
Heenawter authored Jan 4, 2024
1 parent e4cac37 commit 12f57b3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions test/functional/apps/dashboard/group5/embed_mode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ export default function ({
await browser.setWindowSize(1300, 900);
});

// FLAKY: https://github.com/elastic/kibana/issues/163207
describe.skip('default URL params', () => {
describe('default URL params', () => {
it('hides the chrome', async () => {
const globalNavShown = await globalNav.exists();
expect(globalNavShown).to.be(true);
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 12f57b3

Please sign in to comment.