Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Chrome UI Functional Tests.test/functional/apps/dashboard/group5/embed_mode·ts - dashboard app - group 5 embed mode default URL params renders as expected #163207

Open
kibanamachine opened this issue Aug 4, 2023 · 45 comments · Fixed by #163424 or #174193
Open

Failing test: Chrome UI Functional Tests.test/functional/apps/dashboard/group5/embed_mode·ts - dashboard app - group 5 embed mode default URL params renders as expected #163207

kibanamachine opened this issue Aug 4, 2023 · 45 comments · Fixed by #163424 or #174193
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort skipped-test Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.11.1 v8.13.0

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 4, 2023 •
edited
Loading

A test failed on a tracked branch

Error: expected 0.05344176389163536 to be below 0.02
    at Assertion.assert (expect.js:100:11)
    at Assertion.apply (expect.js:336:8)
    at Function.lessThan (expect.js:531:15)
    at Context.<anonymous> (embed_mode.ts:89:41)
    at Object.apply (wrap_function.js:73:16)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Aug 4, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 4, 2023
@kibanamachine kibanamachine added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Aug 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 4, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@ThomThomson ThomThomson added loe:medium Medium Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. labels Aug 4, 2023
@ThomThomson
Copy link
Contributor

ThomThomson commented Aug 4, 2023 •
edited
Loading

I'm not sure how true this is, but this failure where everything is slightly off from the baseline reminds me a lot of the difference in Kibana rendering that we see when using apple silicon vs Intel.

dashboard_embed_mode

Not sure what to do with this one other than to monitor it for a little while try to upgrade the baseline to the apple silicon version if it continues to fail.

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@jbudz
Copy link
Member

jbudz commented Aug 4, 2023

/skip

@kibanamachine
Copy link
Contributor Author

Skipped

main: 1d38289

kibanamachine added a commit that referenced this issue Aug 4, 2023
@kibanamachine
skip failing test suite (#163207)
1d38289
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@nreese nreese self-assigned this Aug 7, 2023
@nreese nreese mentioned this issue Aug 7, 2023
Closed
@nreese
Copy link
Contributor

nreese commented Aug 8, 2023 •
edited
Loading

Unasigning myself so another engineer with ARM mac can generate a fix. Fix is to unskip test and locally rebuild snapshots. Similar to #163361

@nreese nreese removed their assignment Aug 8, 2023
@Heenawter Heenawter self-assigned this Aug 8, 2023
@Heenawter Heenawter mentioned this issue Aug 8, 2023
Merged
2 tasks
Heenawter added a commit that referenced this issue Aug 9, 2023
@Heenawter
[Dashboard] Unskip failing embed_mode screenshot test (#163424)
fd28152 
Closes #163207

## Summary

Since Chrome was updated in the CI environment, our old CI-generated
screenshots were outdated - this PR updates the `embed_mode` screenshot
tests so that we are once again in sync with the CI environment.

For more context, please refer to
#160085

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
bryce-b pushed a commit to bryce-b/kibana that referenced this issue Aug 9, 2023
@kibanamachine @bryce-b
skip failing test suite (elastic#163207)
5e2e805
dej611 pushed a commit to dej611/kibana that referenced this issue Oct 17, 2023
@mistic @dej611
skip flaky suite (elastic#163207)
ebc6a79
@Heenawter Heenawter removed their assignment Oct 18, 2023
@Heenawter Heenawter added v8.13.0 and removed v8.12.0 labels Dec 6, 2023
@Heenawter Heenawter self-assigned this Jan 3, 2024
@Heenawter Heenawter mentioned this issue Jan 3, 2024
Merged
3 tasks
Heenawter added a commit that referenced this issue Jan 4, 2024
@Heenawter
[Dashboard] Update embed mode test screenshot (#174193)
12f57b3 
Closes #163207

## Summary

This PR updates the embed mode baseline screenshot so that the failing
test can be unskipped. This test is, unfortunately, very fragile because
the font rendering is prone to changing between Chrome updates -
however, there isn't really a better way of checking for rendering
issues, so we'll have to continue just updating the baseline whenever a
failure happens 🙈


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed:
- Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4749

![image](https://github.com/elastic/kibana/assets/8698078/eeb87dca-4542-4333-af8b-58d07a8c911e)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine kibanamachine reopened this Aug 23, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - 8.15

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - 8.15

@kibanamachine
Copy link
Contributor Author

New failure: kibana-elasticsearch-snapshot-verify - 8.15

@kibanamachine
Copy link
Contributor Author

New failure: kibana-elasticsearch-snapshot-verify - 8.15

@Heenawter Heenawter removed their assignment Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort skipped-test Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.11.1 v8.13.0
Projects
None yet
Milestone
No milestone
7 participants
@nreese @jbudz @mistic @Heenawter @ThomThomson @elasticmachine @kibanamachine