-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shareable Saved Objects] Add Spaces column to TableListView #172028
Conversation
See MSearch developer example under Content Management
…list' into add-spaces-to-tablelist
@@ -22,7 +22,7 @@ export const applicationServiceFactory: ApplicationServiceFactory = ({ coreStart | |||
navigateToApp, | |||
navigateToUrl, | |||
getUrlForApp, | |||
capabilities: { advancedSettings, maps, navLinks, visualize }, | |||
capabilities: { advancedSettings, maps, navLinks, visualize, savedObjectsManagement }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The savedObjectsManagement
capabilities need to be passed to the TableListViewTable
component to enable or disable the share to space flyout.
src/plugins/event_annotation/public/event_annotation_service/service.tsx
Outdated
Show resolved
Hide resolved
Alternatively, we could probably use an assertion operator as I think all saved objects will have the namespaces property.
src/plugins/dashboard/public/dashboard_listing/hooks/use_dashboard_listing_table.tsx
Outdated
Show resolved
Hide resolved
@@ -228,6 +236,9 @@ export const TableListViewKibanaProvider: FC<TableListViewKibanaDependencies> = | |||
> | |||
<TableListViewProvider | |||
canEditAdvancedSettings={Boolean(core.application.capabilities.advancedSettings?.save)} | |||
canShareToSpaces={Boolean( | |||
core.application.capabilities.savedObjectsManagement.shareIntoSpace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @cqliu1 Is it necessary to disable the share to space flyout like this?
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
Closing this as priorities have shifted. |
Fixes #171461
Part of #167901
Summary
This updates the
TableListViewTable
component to optionally show the Spaces List component.Consumers of the
TableListViewTable
component can pass theSpacesAPI
and anitemIsShareable
handler to display the Spaces column in the table listing. The mSearch developer example app shows how this works. Currently, the only shareable saved objects are Data views (index-pattern
type).Start Kibana with
yarn start --run-examples
and view the developer example at http://localhost:5601/app/contentManagementExamples/msearch.No customer-facing changes are included in this PR.
Dashboard, Event annotation Groups, Files, Graph, and Maps plugins were updated to retrieve the requiredEdit: I removed thenamespaces
saved object property. They are not made shareable in this PR.namespaces
retrieval for these plugins by makingnamespaces
optional in 0b0c990.msearch-spaces-column.mp4
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers