-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shareable Saved Objects] Add Spaces column to TableListView #172028
Closed
Closed
Changes from 14 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
35f2199
Add Spaces column to TableListViewTable component
nickpeihl a8fb8ed
Only show Spaces component for shareable objects
nickpeihl d62272d
Add namespaces property to saved objects
nickpeihl 3683587
Add namespaces to file saved object
nickpeihl edbc376
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 53b984e
Fix types on test
nickpeihl e2dde7e
Merge remote-tracking branch 'refs/remotes/origin/add-spaces-to-table…
nickpeihl b69c8b8
Add savedObjectsManagement to DashboardApplicationService
nickpeihl b96864f
Add unit test for spaces column
nickpeihl affb1b8
Add namespaces to event annotation tests
nickpeihl d8f6254
Add namespaces to graph saved object type
nickpeihl c8be794
Add namespaces to maps listing saved object
nickpeihl 22bebc8
Assert namespaces on dashboard saved object
nickpeihl 8b6c306
Coalesce undefined namespaces to empty array
nickpeihl 64b7c1c
Merge branch 'main' into add-spaces-to-tablelist
nickpeihl 1999276
Revert "Add namespaces property to saved objects"
nickpeihl 3bafc9b
Revert "Add namespaces to file saved object"
nickpeihl 9166573
Revert "Add namespaces to event annotation tests"
nickpeihl 892beab
Revert "Add namespaces to graph saved object type"
nickpeihl b4c87d7
Revert "Add namespaces to maps listing saved object"
nickpeihl 3a17ef0
Merge remote-tracking branch 'refs/remotes/origin/add-spaces-to-table…
nickpeihl 0b0c990
Make namespaces optional in UserContentCommonSchema
nickpeihl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 changes: 68 additions & 0 deletions
68
packages/content-management/table_list_view_table/src/components/spaces_list.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
import React, { FC, useState } from 'react'; | ||
import type { SpacesPluginStart, ShareToSpaceFlyoutProps } from '@kbn/spaces-plugin/public'; | ||
|
||
interface Props { | ||
spacesApi: SpacesPluginStart; | ||
canShareToSpaces?: boolean; | ||
spaceIds: string[]; | ||
type: string; | ||
noun: string; | ||
id: string; | ||
title: string; | ||
refresh(): void; | ||
} | ||
|
||
export const SpacesList: FC<Props> = ({ | ||
spacesApi, | ||
canShareToSpaces, | ||
type, | ||
noun, | ||
spaceIds, | ||
id, | ||
title, | ||
refresh, | ||
}) => { | ||
const [showFlyout, setShowFlyout] = useState(false); | ||
|
||
function onClose() { | ||
setShowFlyout(false); | ||
} | ||
|
||
const LazySpaceList = spacesApi.ui.components.getSpaceList; | ||
const LazyShareToSpaceFlyout = spacesApi.ui.components.getShareToSpaceFlyout; | ||
|
||
const shareToSpaceFlyoutProps: ShareToSpaceFlyoutProps = { | ||
savedObjectTarget: { | ||
type, | ||
namespaces: spaceIds, | ||
id, | ||
title, | ||
noun, | ||
}, | ||
onUpdate: refresh, | ||
onClose, | ||
}; | ||
|
||
const clickProperties = canShareToSpaces | ||
? { cursorStyle: 'pointer', listOnClick: () => setShowFlyout(true) } | ||
: { cursorStyle: 'not-allowed' }; | ||
return ( | ||
<> | ||
<LazySpaceList | ||
namespaces={spaceIds} | ||
displayLimit={8} | ||
behaviorContext="outside-space" | ||
{...clickProperties} | ||
/> | ||
{showFlyout && <LazyShareToSpaceFlyout {...shareToSpaceFlyoutProps} />} | ||
</> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @cqliu1 Is it necessary to disable the share to space flyout like this?