Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add screen reader attributes for API key flyout code editors #169265

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Add screen reader attributes for API key flyout code editors #169265

merged 3 commits into from
Oct 23, 2023

Conversation

SiddharthMantri
Copy link
Contributor

@SiddharthMantri SiddharthMantri commented Oct 18, 2023 •
edited
Loading

Summary

Closes #169127

Fixes

  • Added aria-labels for Access control, Role Descriptors and Metadata code editors

@SiddharthMantri SiddharthMantri added release_note:enhancement Project:Accessibility Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.12.0 labels Oct 18, 2023
@SiddharthMantri SiddharthMantri requested a review from a team as a code owner October 18, 2023 16:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
security 572.2KB 572.7KB +506.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Oct 19, 2023 •
edited
Loading

@elastic/kibana-security is there something I need to do to indicate that translations are needed for this change? (a label maybe?)

@SiddharthMantri SiddharthMantri added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels Oct 19, 2023
thomheymann
thomheymann approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@thomheymann thomheymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

1Copenut
1Copenut reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@1Copenut 1Copenut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SiddharthMantri Hi Sid, I'm Trevor. I'm an accessibility specialist working with Kibana and EUI teams. Would you mind adding a screenshot or URL for this pull request? I'd like to view the aria-label change in view quickly. Much appreciated.

@cee-chen pointed me to the view and I was able to spot-check with VoiceOver briefly. This is a solid improvement, thank you.

@cee-chen
Copy link
Contributor

is there something I need to do to indicate that translations are needed for this change? (a label maybe?)

Nothing needed in this PR, the localization team takes cares of translations before each FF! I'll shoot you a link to the internal documentation if you're curious about how that process works.

@SiddharthMantri SiddharthMantri merged commit 71bbbac into elastic:main Oct 23, 2023
2 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1Copenut 1Copenut 1Copenut approved these changes

@thomheymann thomheymann thomheymann approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve screen reader attributes for API key flyout code editors
7 participants
@SiddharthMantri @elasticmachine @kibana-ci @cee-chen @thomheymann @1Copenut @kibanamachine