Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve screen reader attributes for API key flyout code editors #169127

Closed
SiddharthMantri opened this issue Oct 17, 2023 · 2 comments · Fixed by #169265
Closed

Improve screen reader attributes for API key flyout code editors #169127

SiddharthMantri opened this issue Oct 17, 2023 · 2 comments · Fixed by #169265
Assignees
@SiddharthMantri
Labels
Feature:Users/Roles/API Keys Project:Accessibility Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@SiddharthMantri
Copy link
Contributor

Kibana Version: 8.x

Describe the bug: Currently, the code editors in the API Key creation/editing flyout have no aria-label attribute. This means that the element is not being identified correctly by screen readers which makes them inaccessible.

Expected behavior: The aria attribute should be set correctly and should enable users of screen readers to better understand what that element is.
@SiddharthMantri SiddharthMantri added Project:Accessibility Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Users/Roles/API Keys labels Oct 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@SiddharthMantri SiddharthMantri self-assigned this Oct 17, 2023
@SiddharthMantri SiddharthMantri mentioned this issue Oct 18, 2023
Merged
SiddharthMantri added a commit that referenced this issue Oct 23, 2023
@SiddharthMantri
Add screen reader attributes for API key flyout code editors (#169265)
71bbbac 
## Summary

Closes #169127 


## Fixes

- Added aria-labels for Access control, Role Descriptors and Metadata
code editors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SiddharthMantri SiddharthMantri

Labels
Feature:Users/Roles/API Keys Project:Accessibility Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add screen reader attributes for API key flyout code editors SiddharthMantri/kibana
2 participants
@SiddharthMantri @elasticmachine