Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screen reader attributes for API key flyout code editors #169265

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Add screen reader attributes for API key flyout code editors #169265

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76be93b
add aria-labels for code editors in API Key Flyout
SiddharthMantri Oct 18, 2023
c0eed1b
Merge branch 'main' into aria-labels-api-key-flyout-code-editor
SiddharthMantri Oct 18, 2023
20a6464
Merge branch 'main' into aria-labels-api-key-flyout-code-editor
SiddharthMantri Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_key_flyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,12 @@ export const ApiKeyFlyout: FunctionComponent<ApiKeyFlyoutProps> = ({
<FormField
as={CodeEditorField}
name="access"
aria-label={i18n.translate(
'xpack.security.management.apiKeys.apiKeyFlyout.accessCodeEditor',
{
defaultMessage: 'Code editor for access permissions',
}
)}
value={formik.values.access}
options={{ readOnly: readOnly || (apiKey && !canEdit) }}
onChange={(value: string) => formik.setFieldValue('access', value)}
Expand Down Expand Up @@ -500,6 +506,12 @@ export const ApiKeyFlyout: FunctionComponent<ApiKeyFlyoutProps> = ({
<FormField
as={CodeEditorField}
name="role_descriptors"
aria-label={i18n.translate(
'xpack.security.management.apiKeys.apiKeyFlyout.roleDescriptorsCodeEditor',
{
defaultMessage: 'Code editor for role descriptors of this API key',
}
)}
value={formik.values.role_descriptors}
options={{ readOnly: readOnly || (apiKey && !canEdit) }}
onChange={(value: string) =>
Expand Down Expand Up @@ -631,6 +643,13 @@ export const ApiKeyFlyout: FunctionComponent<ApiKeyFlyoutProps> = ({
<FormField
as={CodeEditorField}
name="metadata"
aria-label={i18n.translate(
'xpack.security.management.apiKeys.apiKeyFlyout.metadataCodeEditor',
{
defaultMessage:
'Code editor for arbitrary metadata associated with the API key',
}
)}
options={{ readOnly: readOnly || (apiKey && !canEdit) }}
value={formik.values.metadata}
onChange={(value: string) => formik.setFieldValue('metadata', value)}
Expand Down
Loading