Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Revert "Fixes unnecessary autocompletes on HTTP methods (#163233)" #168834

Closed

Conversation

yuliacech
Copy link
Contributor

@yuliacech yuliacech commented Oct 13, 2023

Summary

Fixes #168017

After the 8.11 dev cycle there was a regression on the autocomplete suggestions display: suggestions are displayed only after 2 characters are typed (#168017).

This PR reverts the changes in #163233 but since there were several PRs after that, there were several merge conflicts. As a result this PR also reverts the changes in

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@yuliacech yuliacech added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes labels Oct 13, 2023
@yuliacech yuliacech changed the title Revert "Fixes unnecessary autocompletes on HTTP methods (#163233)" [WIP] Revert "Fixes unnecessary autocompletes on HTTP methods (#163233)" Oct 13, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 13, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #2 / Integration Cursor rows after request end

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 403.6KB 401.5KB -2.0KB
Unknown metric groups

ESLint disabled line counts

id before after diff
console 38 37 -1

Total ESLint disabled count

id before after diff
console 41 40 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yuliacech yuliacech closed this Nov 2, 2023
@yuliacech yuliacech deleted the console/revert_http_method_fix branch February 15, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Console] Autocomplete for url parameters works only after 2 characters
2 participants