Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PATCH requests in Console #165634

Merged
merged 8 commits into from
Sep 9, 2023
Merged

Add support for PATCH requests in Console #165634

merged 8 commits into from
Sep 9, 2023

Conversation

sakurai-youhei
Copy link
Member

Summary

This PR adds support for PATCH requests in Console.

patch-request

Closes #154274

Checklist

For maintainers

Release note

Adds support for PATCH requests in Console.

@sakurai-youhei sakurai-youhei added release_note:enhancement Feature:Console Dev Tools Console Feature enhancement New value added to drive a business result labels Sep 5, 2023
@sakurai-youhei sakurai-youhei requested a review from a team as a code owner September 5, 2023 01:54
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Documentation preview:

@sakurai-youhei
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine kibanamachine requested a review from a team as a code owner September 5, 2023 02:26
@sakurai-youhei sakurai-youhei marked this pull request as draft September 5, 2023 13:25
@sakurai-youhei sakurai-youhei marked this pull request as ready for review September 6, 2023 09:23
@yuliacech yuliacech self-requested a review September 8, 2023 10:19
yuliacech
yuliacech approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this, @sakurai-youhei! Tested locally and changes LGTM 👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 418.3KB 418.6KB +380.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sakurai-youhei sakurai-youhei merged commit b46a737 into elastic:main Sep 9, 2023
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Sep 9, 2023
@alisonelizabeth alisonelizabeth added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Oct 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@yuliacech yuliacech mentioned this pull request Oct 13, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliacech yuliacech yuliacech approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting enhancement New value added to drive a business result Feature:Console Dev Tools Console Feature release_note:enhancement Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support PATCH requests in dev tools console
6 participants
@sakurai-youhei @kibana-ci @elasticmachine @yuliacech @alisonelizabeth @kibanamachine