Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocomplete on only 1 letter typed in request editor #164707

Merged

Conversation

sakurai-youhei
Copy link
Member

Summary

This PR fixes autocomplete on only 1 letter typed in request editor.

Closes #164542

Checklist

For maintainers

Release note

Fixes autocomplete on only 1 letter typed in Console's request editor

@sakurai-youhei sakurai-youhei added bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature release_note:fix backport:skip This commit does not require backporting labels Aug 24, 2023
@sakurai-youhei sakurai-youhei requested a review from a team as a code owner August 24, 2023 12:54
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #10 / lens app - group 5 lens visualize geo field tests should visualize geo fields in maps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 418.3KB 418.2KB -105.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sakurai-youhei
Copy link
Member Author

Note that tests were not disabled at the time of build 153141, which proves the proposed fix by them. Refer HERE.

I recommend merging #164706 first, which lets you check whether or not this fix breaks behaviors described in #136056.

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this, @sakurai-youhei!
Tested locally and was not able to reproduce the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature release_note:fix v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Console] Autocomplete doesn't work when only 1 letter is typed in
4 participants