Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Console's autocomplete #136056

Closed
4 tasks
cjcenizal opened this issue Jul 8, 2022 · 1 comment · Fixed by #164706
Closed
4 tasks

Add tests for Console's autocomplete #136056

cjcenizal opened this issue Jul 8, 2022 · 1 comment · Fixed by #164706
Labels
Feature:Console Dev Tools Console Feature Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more test-coverage issues & PRs for improving code test coverage

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Jul 8, 2022

Summary

Let's add functional tests to document and verify autocomplete behavior in Console:

  • HTTP methods
  • ES API endpoints
  • JSON autocompletion with placeholder fields
  • Dynamic autocomplete

Autocomplete behavior

HTTP methods

Console autocomplete will suggest HTTP methods POST, GET, etc.

ES API endpoints

Console autocomplete will suggest different endpoints based on the method you've used and any input you've typed. Some users have complained that this matching logic is too liberal (#13361).

image

JSON autocompletion with placeholder fields

Autocomplete also works for the JSON body, and will complete with nested JSON objects with placeholder field names.

aggs_autocomplete

Dynamic autocomplete

Console can suggest indices, fields, and other things that the user has created. So we need the ability to update the autocomplete rules during run-time. In the example below, "test" is an index the user created.

image

@cjcenizal cjcenizal added Feature:Console Dev Tools Console Feature Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more test-coverage issues & PRs for improving code test coverage labels Jul 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

sakurai-youhei added a commit that referenced this issue Sep 1, 2023
## Summary

This PR adds functional tests for Console's autocomplete, all suggested
in #136056.

Closes #136056

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Console Dev Tools Console Feature Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more test-coverage issues & PRs for improving code test coverage
Projects
None yet
2 participants