Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Workspace panel dimensions by chart type #168651

Merged

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Oct 11, 2023

Summary

Close #136993

All charts remain the same except the following

Metric

Each tile gets 200px if there are multiple and 300px if it's a single. The default background is EUI empty.

Screenshot 2023-10-30 at 3 55 33 PM Screenshot 2023-10-30 at 3 56 36 PM

XY

Vertical time-series charts have 16:9 ratio but will stretch to any available width and won't shrink below 300px height.

Screen.Recording.2024-01-10.at.2.26.10.PM.mov

Gauge

Gauge gets 600px for the long side, 300px for the short side.

Screenshot 2023-11-28 at 11 22 20 AM Screenshot 2023-11-28 at 11 22 33 AM

Known issues

Screen.Recording.2023-11-08.at.1.50.42.PM.mov
  • gauge isn't showing veil on willRender

Checklist

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4755

@drewdaemon drewdaemon force-pushed the 136993/workspace-dimensions-by-chart-type branch from 893fd79 to e4f2bd9 Compare October 23, 2023 19:51
@drewdaemon drewdaemon removed the skip-ci label Nov 8, 2023
@drewdaemon
Copy link
Contributor Author

@elasticmachine merge upstream

@gvnmagni
Copy link

@markov00 @gvnmagni have I made your wildest dreams come true?

Screen.Recording.2024-01-10.at.2.26.10.PM.mov

This is perfect! 😍

@markov00
Copy link
Member

@markov00 @gvnmagni have I made your wildest dreams come true?

Perfect thanks!

Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for making those earlier fixes, @drewdaemon. I've left a few small comments for your re-review, but nothing worth holding you up over. Assuming you're able to address them, I'll approve now.

@elastic elastic deleted a comment from kibana-ci Jan 11, 2024
@elastic elastic deleted a comment from kibana-ci Jan 12, 2024
@drewdaemon drewdaemon requested a review from a team as a code owner January 12, 2024 19:04
@elastic elastic deleted a comment from kibana-ci Jan 12, 2024
@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Jan 12, 2024
@drewdaemon
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
expressionGauge 88 91 +3
expressionHeatmap 150 153 +3
expressionLegacyMetricVis 33 36 +3
expressionMetricVis 91 94 +3
expressionPartitionVis 165 168 +3
expressionTagcloud 139 142 +3
expressionXY 225 228 +3
lens 1210 1212 +2
visualizations 366 372 +6
total +29

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/chart-expressions-common 10 22 +12
expressions 1752 1757 +5
total +17

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1013.8KB 1013.8KB +35.0B
expressionGauge 18.7KB 19.0KB +302.0B
expressionHeatmap 26.5KB 26.5KB -1.0B
expressionLegacyMetricVis 11.9KB 11.9KB -1.0B
expressionMetricVis 4.8KB 5.0KB +133.0B
expressionPartitionVis 40.8KB 40.8KB -2.0B
expressionTagcloud 23.2KB 23.2KB +1.0B
expressionXY 132.3KB 132.6KB +337.0B
lens 1.4MB 1.4MB +1.3KB
visualizations 269.9KB 270.6KB +795.0B
total +2.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionGauge 14.7KB 16.5KB +1.8KB
expressionHeatmap 14.8KB 15.7KB +869.0B
expressionLegacyMetricVis 10.2KB 11.0KB +859.0B
expressionMetricVis 13.8KB 14.5KB +725.0B
expressionPartitionVis 26.7KB 27.5KB +868.0B
expressions 98.5KB 98.7KB +273.0B
expressionTagcloud 10.8KB 11.7KB +874.0B
expressionXY 38.9KB 40.7KB +1.8KB
maps 47.1KB 47.3KB +115.0B
visualizations 57.1KB 57.2KB +54.0B
total +8.1KB
Unknown metric groups

API count

id before after diff
@kbn/chart-expressions-common 14 27 +13
expressions 2211 2219 +8
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon
Copy link
Contributor Author

@drewdaemon drewdaemon merged commit e6a5647 into elastic:main Jan 14, 2024
21 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 14, 2024
stratoula added a commit that referenced this pull request Jan 15, 2024
## Summary

This PR #168651 broke (from the UI
perspective) the suggested metric.

How it looks in main
<img width="1886" alt="image"
src="https://github.com/elastic/kibana/assets/17003240/cc8a244c-e1af-4fa7-9550-f72c16bd8ca2">

How it looks in this PR
<img width="1984" alt="image"
src="https://github.com/elastic/kibana/assets/17003240/c0d4ea9d-59e2-4f49-bb24-5ba8dfffe634">

It follows the same logic as the PR which broke it and adds a box-shadow
to distinguish the chart from the background
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:Lens release_note:feature Makes this part of the condensed release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] workspace panel dimensions by chart type