-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Workspace panel dimensions by chart type #168651
[Lens] Workspace panel dimensions by chart type #168651
Conversation
893fd79
to
e4f2bd9
Compare
…e-dimensions-by-chart-type
…e-dimensions-by-chart-type
…e-dimensions-by-chart-type
…e-dimensions-by-chart-type
@elasticmachine merge upstream |
…m:drewdaemon/kibana into 136993/workspace-dimensions-by-chart-type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for making those earlier fixes, @drewdaemon. I've left a few small comments for your re-review, but nothing worth holding you up over. Assuming you're able to address them, I'll approve now.
src/plugins/chart_expressions/common/chart_size_transition_veil.tsx
Outdated
Show resolved
Hide resolved
src/plugins/chart_expressions/expression_metric/public/components/metric_vis.tsx
Outdated
Show resolved
Hide resolved
...s/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel_wrapper.scss
Outdated
Show resolved
Hide resolved
…m:drewdaemon/kibana into 136993/workspace-dimensions-by-chart-type
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
Flaky test runner passed again https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4859#018cffae-0178-4df7-8091-c75e60d3299e |
## Summary This PR #168651 broke (from the UI perspective) the suggested metric. How it looks in main <img width="1886" alt="image" src="https://github.com/elastic/kibana/assets/17003240/cc8a244c-e1af-4fa7-9550-f72c16bd8ca2"> How it looks in this PR <img width="1984" alt="image" src="https://github.com/elastic/kibana/assets/17003240/c0d4ea9d-59e2-4f49-bb24-5ba8dfffe634"> It follows the same logic as the PR which broke it and adds a box-shadow to distinguish the chart from the background
Summary
Close #136993
All charts remain the same except the following
Metric
Each tile gets
200px
if there are multiple and300px
if it's a single. The default background is EUI empty.XY
Vertical time-series charts have
16:9
ratio but will stretch to any available width and won't shrink below 300px height.Screen.Recording.2024-01-10.at.2.26.10.PM.mov
Gauge
Gauge gets
600px
for the long side,300px
for the short side.Known issues
Screen.Recording.2023-11-08.at.1.50.42.PM.mov
Checklist
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4755