Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL][Discover] Adds a box-shadow to suggested metric vis #174821

Merged
merged 1 commit into from
Jan 15, 2024
Merged

[ES|QL][Discover] Adds a box-shadow to suggested metric vis #174821

merged 1 commit into from
Jan 15, 2024

Conversation

stratoula
Copy link
Contributor

Summary

This PR #168651 broke (from the UI perspective) the suggested metric.

How it looks in main
image

How it looks in this PR
image

It follows the same logic as the PR which broke it and adds a box-shadow to distinguish the chart from the background

@stratoula stratoula changed the title [ES|QL] Adds a box-shadow to suggested metric vis [ES|QL][Discover] Adds a box-shadow to suggested metric vis Jan 15, 2024
@stratoula
Copy link
Contributor Author

/ci

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana v8.13.0 Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jan 15, 2024
@stratoula stratoula marked this pull request as ready for review January 15, 2024 09:18
@stratoula stratoula requested a review from a team as a code owner January 15, 2024 09:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

jughosta
jughosta approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stratoula stratoula enabled auto-merge (squash) January 15, 2024 09:58
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedHistogram 69.3KB 69.4KB +144.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 0008e85 into elastic:main Jan 15, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jughosta jughosta jughosta approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stratoula @elasticmachine @kibana-ci @jughosta