Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated EUI components in kibana_react #166225

Merged
merged 27 commits into from
Sep 25, 2023
Merged

Remove deprecated EUI components in kibana_react #166225

merged 27 commits into from
Sep 25, 2023

Conversation

vadimkibana
Copy link
Contributor

@vadimkibana vadimkibana commented Sep 12, 2023 •
edited
Loading

Summary

Closes #161422

In this PR:

  • Removes KibanaPageTemplate utilities from kibana_react
  • Migrates remaining users of KibanaPageTemplate from kibana_react to the one from @kbn/shared-ux-page-kibana-template
    • src/plugins/home/public/application/components/tutorial_directory.js
    • src/plugins/home/public/application/components/tutorial/tutorial.js
    • x-pack/plugins/osquery/public/components/empty_state.tsx

Visual Changes

Below are the main visual differences this PR introduces.

Sample data page before:

Screenshot 2023-09-13 at 12 12 11

Sample data page now:

Screenshot 2023-09-13 at 12 12 18

Tutorials page before:

Screenshot 2023-09-13 at 13 09 58

Tutorials page now:

Screenshot 2023-09-13 at 13 10 04

@vadimkibana vadimkibana mentioned this pull request Sep 12, 2023
Closed
@vadimkibana vadimkibana changed the title use new EuiPageTemplate component Remove deprecated EUI components in kibana_react Sep 12, 2023
@vadimkibana vadimkibana added review release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.11.0 labels Sep 12, 2023
@vadimkibana vadimkibana marked this pull request as ready for review September 12, 2023 12:31
@vadimkibana vadimkibana requested review from a team as code owners September 12, 2023 12:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

cee-chen
cee-chen approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM! I didn't pull down to QA, let me know if you want me to

src/plugins/kibana_react/public/page_template/page_template.test.tsx Outdated Show resolved Hide resolved
@vadimkibana vadimkibana marked this pull request as draft September 13, 2023 09:10
@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@vadimkibana vadimkibana marked this pull request as ready for review September 14, 2023 09:12
cee-chen
cee-chen approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Huge +1 to to deleting deprecated components! Again, I didn't pull this down to QA changes, but if anything is off from before feel free to rope me in to help.

@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@vadimkibana vadimkibana enabled auto-merge (squash) September 18, 2023 12:11
tomsonpl
tomsonpl approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defend workflows LGTM 👍

@vadimkibana vadimkibana added ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment labels Sep 19, 2023
auto-merge was automatically disabled September 19, 2023 08:42

Head branch was pushed to by a user without write access

@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

cee-chen
cee-chen approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM! Again, no QA here, but feel free to ping me if anything comes up that I can help with

Dosant
Dosant approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Dosant
Copy link
Contributor

Dosant commented Sep 22, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 22, 2023 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
kibanaReact 327 314 -13
osquery 280 336 +56
total +43

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
kibanaReact 147 138 -9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1011.6KB 1011.7KB +66.0B
dashboard 355.5KB 355.5KB +66.0B
enterpriseSearch 2.6MB 2.6MB +66.0B
eventAnnotationListing 197.3KB 197.3KB +66.0B
filesManagement 89.6KB 89.7KB +66.0B
graph 387.7KB 387.7KB +66.0B
home 164.2KB 164.3KB +79.0B
indexManagement 601.6KB 601.6KB +66.0B
infra 2.0MB 2.0MB +66.0B
kibanaOverview 44.9KB 45.0KB +66.0B
kibanaReact 213.0KB 212.9KB -14.0B
management 42.4KB 42.5KB +66.0B
maps 2.8MB 2.8MB +66.0B
ml 3.5MB 3.5MB +66.0B
observabilityShared 35.9KB 35.9KB +66.0B
osquery 1.0MB 1.0MB +18.7KB
security 571.4KB 571.5KB +66.0B
securitySolution 12.8MB 12.8MB +132.0B
securitySolutionEss 42.4KB 42.4KB +66.0B
securitySolutionServerless 289.9KB 290.0KB +66.0B
spaces 173.8KB 173.9KB +66.0B
visualizations 265.6KB 265.7KB +66.0B
total +20.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
kibanaReact 5 4 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esUiShared 156.3KB 156.3KB +66.0B
kibanaReact 54.3KB 47.8KB -6.5KB
osquery 51.2KB 51.2KB +56.0B
total -6.4KB
Unknown metric groups

API count

id before after diff
kibanaReact 186 176 -10

miscellaneous assets size

id before after diff
osquery 0.0B 161.8KB +161.8KB

References to deprecated APIs

id before after diff
home 78 71 -7
osquery 24 22 -2
total -9

Unreferenced deprecated APIs

id before after diff
kibanaReact 4 3 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@vadimkibana vadimkibana merged commit dfcf60a into elastic:main Sep 25, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlog kevinlog kevinlog approved these changes

@tomsonpl tomsonpl tomsonpl approved these changes

@Dosant Dosant Dosant approved these changes

@cee-chen cee-chen cee-chen approved these changes

@joeypoon joeypoon Awaiting requested review from joeypoon joeypoon is a code owner automatically assigned from elastic/security-defend-workflows

@dasansol92 dasansol92 Awaiting requested review from dasansol92 dasansol92 is a code owner automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment release_note:skip Skip the PR/issue when compiling release notes review Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Shared UX] Migrate all usages of EuiPage*_Deprecated
8 participants
@vadimkibana @elasticmachine @Dosant @kibana-ci @cee-chen @tomsonpl @kevinlog @kibanamachine