Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated EUI components in kibana_react #166225

Merged
merged 27 commits into from
Sep 25, 2023
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
7266cdc
use new EuiPageTemplate component
vadimkibana Sep 12, 2023
cb77901
remove deprecated component tests
vadimkibana Sep 12, 2023
d4e73a4
change more deprecated components
vadimkibana Sep 12, 2023
a16bf0e
replace deprecated type
vadimkibana Sep 12, 2023
52604dd
revert back page template changes
vadimkibana Sep 13, 2023
4d97fd2
use new page template
vadimkibana Sep 13, 2023
eab2cec
use new template component in <Tutorial> component
vadimkibana Sep 13, 2023
7d22ec6
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine Sep 13, 2023
417a753
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Sep 13, 2023
ed4ae0e
Merge branch 'main' into eui-deprecations-kibana_react
kibanamachine Sep 13, 2023
967a22e
Merge branch 'main' into eui-deprecations-kibana_react
kibanamachine Sep 13, 2023
c49005d
update Jest snapshots
vadimkibana Sep 14, 2023
48c86ba
use new Kibana template in Osquery
vadimkibana Sep 13, 2023
1a9a686
remove page template from kibana_react
vadimkibana Sep 13, 2023
8c02f5d
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Sep 14, 2023
31e5ef3
Merge branch 'main' into eui-deprecations-kibana_react
kibanamachine Sep 18, 2023
fef3537
expose minHeight prop and use default value in tuts
vadimkibana Sep 18, 2023
d74f14c
Merge remote-tracking branch 'upstream/main' into eui-deprecations-ki…
vadimkibana Sep 19, 2023
ddfefd6
calculate page height using calc()
vadimkibana Sep 19, 2023
d55a8a5
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine Sep 19, 2023
f0cd3d6
Merge remote-tracking branch 'upstream/main' into eui-deprecations-ki…
vadimkibana Sep 19, 2023
e20b44f
update test snapshot
vadimkibana Sep 20, 2023
457bf27
update test snapshot
vadimkibana Sep 20, 2023
bfcc4c3
Merge branch 'main' into eui-deprecations-kibana_react
kibanamachine Sep 20, 2023
42fc07d
Merge branch 'main' into eui-deprecations-kibana_react
kibanamachine Sep 21, 2023
7da0bea
apply review suggestion
vadimkibana Sep 21, 2023
a6d44b6
Merge branch 'main' into eui-deprecations-kibana_react
kibanamachine Sep 22, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export const KibanaPageTemplateInner: FC<Props> = ({
isEmptyState,
pageSideBar,
pageSideBarProps,
minHeight = 0,
...rest
}) => {
let header;
Expand Down Expand Up @@ -68,7 +69,7 @@ export const KibanaPageTemplateInner: FC<Props> = ({
// the following props can be removed to allow the template to auto-handle
// the fixed header and banner heights.
offset={0}
minHeight={0}
minHeight={minHeight}
{...rest}
>
{sideBar}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import * as StatusCheckStates from './status_check_states';
import { injectI18n, FormattedMessage } from '@kbn/i18n-react';
import { i18n } from '@kbn/i18n';
import { getServices } from '../../kibana_services';
import { KibanaPageTemplate } from '@kbn/kibana-react-plugin/public';
import { KibanaPageTemplate } from '@kbn/shared-ux-page-kibana-template';

const INSTRUCTIONS_TYPE = {
ELASTIC_CLOUD: 'elasticCloud',
Expand Down Expand Up @@ -360,7 +360,7 @@ class TutorialUi extends React.Component {
render() {
let content;
if (this.state.notFound) {
content = (
return (
<KibanaPageTemplate
isEmptyState={true}
pageHeader={{
Expand Down Expand Up @@ -435,7 +435,11 @@ class TutorialUi extends React.Component {
);
}

return <KibanaPageTemplate template="empty">{content}</KibanaPageTemplate>;
return (
<KibanaPageTemplate template="empty">
<KibanaPageTemplate.Section>{content}</KibanaPageTemplate.Section>
</KibanaPageTemplate>
);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { SampleDataTab } from '@kbn/home-sample-data-tab';
import { i18n } from '@kbn/i18n';
import { Synopsis } from './synopsis';
import { getServices } from '../kibana_services';
import { KibanaPageTemplate } from '@kbn/kibana-react-plugin/public';
import { KibanaPageTemplate } from '@kbn/shared-ux-page-kibana-template';
import { getTutorials } from '../load_tutorials';

const SAMPLE_DATA_TAB_ID = 'sampleData';
Expand Down Expand Up @@ -256,8 +256,9 @@ class TutorialDirectoryUi extends React.Component {
tabs,
rightSideItems: headerLinks ? [headerLinks] : [],
}}
minHeight={'460px'}
>
{this.renderTabContent()}
<KibanaPageTemplate.Section>{this.renderTabContent()}</KibanaPageTemplate.Section>
vadimkibana marked this conversation as resolved.
Show resolved Hide resolved
</KibanaPageTemplate>
);
}
Expand Down
4 changes: 0 additions & 4 deletions src/plugins/kibana_react/public/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,17 +54,13 @@ export { POSITIONS, WEIGHTS, TOOLBAR_BUTTON_SIZES, ToolbarButton } from './toolb
export { reactRouterNavigate, reactRouterOnClickHandler } from './react_router_navigate';

export type {
KibanaPageTemplateProps,
NoDataPageActions,
NoDataPageActionsProps,
NoDataPageProps,
ElasticAgentCardProps,
} from './page_template';
export {
KibanaPageTemplate,
KibanaPageTemplateSolutionNavAvatar,
NO_DATA_PAGE_MAX_WIDTH,
NO_DATA_PAGE_TEMPLATE_PROPS,
NO_DATA_RECOMMENDED,
NoDataPage,
ElasticAgentCard,
Expand Down
Loading