-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove deprecated EUI components in kibana_react (#166225)
## Summary Closes #161422 In this PR: - [x] Removes `KibanaPageTemplate` utilities from `kibana_react` - [x] Migrates remaining users of `KibanaPageTemplate` from `kibana_react` to the one from `@kbn/shared-ux-page-kibana-template` - [x] `src/plugins/home/public/application/components/tutorial_directory.js` - [x] `src/plugins/home/public/application/components/tutorial/tutorial.js` - [x] `x-pack/plugins/osquery/public/components/empty_state.tsx` ## Visual Changes Below are the main visual differences this PR introduces. Sample data page before: <img width="1419" alt="Screenshot 2023-09-13 at 12 12 11" src="https://github.com/elastic/kibana/assets/82822460/cbad5bd2-9c51-486c-a48d-ac44a80cdbf7"> Sample data page now: <img width="1456" alt="Screenshot 2023-09-13 at 12 12 18" src="https://github.com/elastic/kibana/assets/82822460/4118db78-89e8-41ed-a3d3-51a221dde857"> Tutorials page before: <img width="1402" alt="Screenshot 2023-09-13 at 13 09 58" src="https://github.com/elastic/kibana/assets/82822460/b51af548-211a-4a59-9143-b82f2ff55678"> Tutorials page now: <img width="1439" alt="Screenshot 2023-09-13 at 13 10 04" src="https://github.com/elastic/kibana/assets/82822460/f71590a3-7c3d-4f60-a460-47aacdfcbf09"> --------- Co-authored-by: kibanamachine <[email protected]>
- Loading branch information
1 parent
a712426
commit dfcf60a
Showing
21 changed files
with
157 additions
and
1,092 deletions.
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
packages/shared-ux/page/kibana_template/impl/src/__snapshots__/page_template.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
3 changes: 2 additions & 1 deletion
3
...s/shared-ux/page/kibana_template/impl/src/__snapshots__/page_template_inner.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
276 changes: 141 additions & 135 deletions
276
src/plugins/home/public/application/components/tutorial/__snapshots__/tutorial.test.js.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.