Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Expandable flyout - update risk classification ui in entities overview #165022

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

christineweng
Copy link
Contributor

@christineweng christineweng commented Aug 28, 2023

Summary

This PR updates the right section of Expandable flyout -> Overview tab -> Insights -> Entities overview

  • In cases when risk classification is not available, an empty tag is shown instead of Unknown as previously presented
  • Added back tech preview tooltip icon to stay consistent with tech preview badge in the old flyout

image

Checklist

Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and LGTM! thanks for making this so quickly! :)

@christineweng christineweng force-pushed the 164549-risk-score-empty-tag branch from 113d635 to 125adaa Compare August 28, 2023 21:13
@christineweng christineweng enabled auto-merge (squash) August 28, 2023 21:15
@christineweng christineweng merged commit e574281 into elastic:main Aug 28, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.5MB 12.5MB +1.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @christineweng

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 28, 2023
… in entities overview (elastic#165022)

## Summary

This PR updates the right section of Expandable flyout -> Overview tab
-> Insights -> Entities overview

- In cases when risk classification is not available, an empty tag is
shown instead of `Unknown` as previously presented
- Added back tech preview tooltip icon to stay consistent with tech
preview badge in the old flyout

![image](https://github.com/elastic/kibana/assets/18648970/a18b02d7-42ac-46fc-b58e-39fb94bb3c50)

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit e574281)
kibanamachine added a commit that referenced this pull request Aug 28, 2023
…tion ui in entities overview (#165022) (#165052)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Security Solution] Expandable flyout - update risk classification ui
in entities overview
(#165022)](#165022)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-28T22:20:20Z","message":"[Security
Solution] Expandable flyout - update risk classification ui in entities
overview (#165022)\n\n## Summary\r\n\r\nThis PR updates the right
section of Expandable flyout -> Overview tab\r\n-> Insights -> Entities
overview\r\n\r\n- In cases when risk classification is not available, an
empty tag is\r\nshown instead of `Unknown` as previously presented\r\n-
Added back tech preview tooltip icon to stay consistent with
tech\r\npreview badge in the old
flyout\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/18648970/a18b02d7-42ac-46fc-b58e-39fb94bb3c50)\r\n\r\n###
Checklist\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"e574281fbaaf766c88d9062f6f2e5b6ef3956a96","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat
Hunting:Investigations","v8.10.0","v8.11.0"],"number":165022,"url":"https://github.com/elastic/kibana/pull/165022","mergeCommit":{"message":"[Security
Solution] Expandable flyout - update risk classification ui in entities
overview (#165022)\n\n## Summary\r\n\r\nThis PR updates the right
section of Expandable flyout -> Overview tab\r\n-> Insights -> Entities
overview\r\n\r\n- In cases when risk classification is not available, an
empty tag is\r\nshown instead of `Unknown` as previously presented\r\n-
Added back tech preview tooltip icon to stay consistent with
tech\r\npreview badge in the old
flyout\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/18648970/a18b02d7-42ac-46fc-b58e-39fb94bb3c50)\r\n\r\n###
Checklist\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"e574281fbaaf766c88d9062f6f2e5b6ef3956a96"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165022","number":165022,"mergeCommit":{"message":"[Security
Solution] Expandable flyout - update risk classification ui in entities
overview (#165022)\n\n## Summary\r\n\r\nThis PR updates the right
section of Expandable flyout -> Overview tab\r\n-> Insights -> Entities
overview\r\n\r\n- In cases when risk classification is not available, an
empty tag is\r\nshown instead of `Unknown` as previously presented\r\n-
Added back tech preview tooltip icon to stay consistent with
tech\r\npreview badge in the old
flyout\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/18648970/a18b02d7-42ac-46fc-b58e-39fb94bb3c50)\r\n\r\n###
Checklist\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"e574281fbaaf766c88d9062f6f2e5b6ef3956a96"}}]}]
BACKPORT-->

Co-authored-by: christineweng <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 29, 2023
* main: (40 commits)
  Adjust migrations and elasticsearch service settings for serverless. (elastic#165050)
  [Security Solution] expandable flyout - add investigate in timeline f… (elastic#165025)
  [SecuritySolution] Hide create dashboard button from listing (elastic#164476)
  Construct HTTP log message only if needed (elastic#165057)
  [Security Solution] expandable flyout - add no data message in entities details and entities overview components (elastic#164955)
  Add functional tests for serverless security management UIs (elastic#164886)
  [api-docs] 2023-08-29 Daily api_docs build (elastic#165056)
  [Cloud Security][CIS GCP]cis gcp now use updated gcp field name + small last minute changes (elastic#164792)
  [Security Solution] Expandable flyout - update risk classification ui in entities overview (elastic#165022)
  [Security Solution] Fixes Preconfigured Connectors not working with Assistant (elastic#164900)
  [Security Solution] Coverage Overview follow-up 2 (elastic#164986)
  [DOCS] Add cross-link for other encryption key settings (elastic#165014)
  chore(slo): general enhancement (elastic#164723)
  Revert "[SOR] Allow optionally downgrading documents with a higher version model in API READ methods" (elastic#164991)
  [OAS] Add more Elasticsearch query rule examples (elastic#164386)
  [security_solution_cypress] Add support for options in EsArchiver.load (elastic#164988)
  [Event Log] Skip setting assets to hidden in serverless (elastic#164767)
  remove unneeded usages of isErrorResponse (elastic#164609)
  [Enterprise Search] Make network drive connector platinum (elastic#165007)
  [RAM] update api key to become public (elastic#164883)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants