[Security Solution] expandable flyout - add no data message in entities details and entities overview components #164955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:enhancement
Team:Threat Hunting:Investigations
x-pack/plugins/security_solution/public/flyout/left/components/entities_details.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/flyout/right/components/entities_overview.tsx
Outdated
Show resolved
Hide resolved
christineweng
approved these changes
Aug 28, 2023
…es details and entities overview components
PhilippeOberti
force-pushed
the
expandable-flyout-entities-details-no-data
branch
from
44abad5 to
a3964c2
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 29, 2023
…es details and entities overview components (elastic#164955) (cherry picked from commit 34c7a03)
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 29, 2023
* main: (40 commits) Adjust migrations and elasticsearch service settings for serverless. (elastic#165050) [Security Solution] expandable flyout - add investigate in timeline f… (elastic#165025) [SecuritySolution] Hide create dashboard button from listing (elastic#164476) Construct HTTP log message only if needed (elastic#165057) [Security Solution] expandable flyout - add no data message in entities details and entities overview components (elastic#164955) Add functional tests for serverless security management UIs (elastic#164886) [api-docs] 2023-08-29 Daily api_docs build (elastic#165056) [Cloud Security][CIS GCP]cis gcp now use updated gcp field name + small last minute changes (elastic#164792) [Security Solution] Expandable flyout - update risk classification ui in entities overview (elastic#165022) [Security Solution] Fixes Preconfigured Connectors not working with Assistant (elastic#164900) [Security Solution] Coverage Overview follow-up 2 (elastic#164986) [DOCS] Add cross-link for other encryption key settings (elastic#165014) chore(slo): general enhancement (elastic#164723) Revert "[SOR] Allow optionally downgrading documents with a higher version model in API READ methods" (elastic#164991) [OAS] Add more Elasticsearch query rule examples (elastic#164386) [security_solution_cypress] Add support for options in EsArchiver.load (elastic#164988) [Event Log] Skip setting assets to hidden in serverless (elastic#164767) remove unneeded usages of isErrorResponse (elastic#164609) [Enterprise Search] Make network drive connector platinum (elastic#165007) [RAM] update api key to become public (elastic#164883) ...
kibanamachine
added a commit
that referenced
this pull request
Aug 29, 2023
… entities details and entities overview components (#164955) (#165062) # Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution] expandable flyout - add no data message in entities details and entities overview components (#164955)](#164955) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-29T07:54:40Z","message":"[Security Solution] expandable flyout - add no data message in entities details and entities overview components (#164955)","sha":"34c7a03016138cc1bae8296e1bb25bf4e73a8f4d","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Threat Hunting:Investigations","v8.10.0","v8.11.0"],"number":164955,"url":"https://github.com/elastic/kibana/pull/164955","mergeCommit":{"message":"[Security Solution] expandable flyout - add no data message in entities details and entities overview components (#164955)","sha":"34c7a03016138cc1bae8296e1bb25bf4e73a8f4d"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164955","number":164955,"mergeCommit":{"message":"[Security Solution] expandable flyout - add no data message in entities details and entities overview components (#164955)","sha":"34c7a03016138cc1bae8296e1bb25bf4e73a8f4d"}}]}] BACKPORT--> Co-authored-by: Philippe Oberti <[email protected]>
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a no-data message to the entities details and entities overview section (in the expandable left and right panels respectively).
The entities details was showing a blank page, which isn't UX friendly.
The entities overview show hiding its section, which was a desired behavior in an earlier implementation. We recently switched to always showing all sections, and render a no-data message if nothing is to be displayed.
With data
No data previous behavior
No data new behavior (with no-data message)
Fixes #164951
Checklist
Delete any items that are not applicable to this PR.