Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Hide create dashboard button from listing #164476

Merged
merged 11 commits into from
Aug 29, 2023
Merged

[SecuritySolution] Hide create dashboard button from listing #164476

merged 11 commits into from
Aug 29, 2023

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Aug 22, 2023 •
edited by kibanamachine
Loading

Summary

original issue: #163459

Before - Two Create Dashboard buttons on Security Dashboard
image

After - Create dashboard button from listing is removed.
Screenshot 2023-08-22 at 16 45 56

Checklist

Delete any items that are not applicable to this PR.

@angorayc angorayc changed the title Hide create dashboard button from listing [SecuritySolution] Hide create dashboard button from listing Aug 22, 2023
@angorayc angorayc added Feature:Dashboard Dashboard related features release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.10.0 v8.11.0 Feature:Security Dashboards Security solution custom dashboards feature and removed Feature:Dashboard Dashboard related features labels Aug 22, 2023
@angorayc angorayc added the ci:cloud-deploy Create or update a Cloud deployment label Aug 23, 2023
@angorayc angorayc added ci:cloud-redeploy Always create a new Cloud deployment and removed ci:cloud-deploy Create or update a Cloud deployment labels Aug 23, 2023
@angorayc angorayc removed the ci:cloud-redeploy Always create a new Cloud deployment label Aug 23, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 368.6KB 368.7KB +95.0B
securitySolution 15.7MB 15.7MB +29.0B
total +124.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc marked this pull request as ready for review August 24, 2023 12:04
@angorayc angorayc requested review from a team as code owners August 24, 2023 12:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

ThomThomson
ThomThomson approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team changes LGTM! Nice and straightforward.

@angorayc angorayc mentioned this pull request Aug 24, 2023
Merged
3 tasks
machadoum
machadoum approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@angorayc angorayc merged commit d63dd9d into elastic:main Aug 29, 2023
@kibanamachine kibanamachine mentioned this pull request Aug 29, 2023
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 29, 2023
@angorayc
[SecuritySolution] Hide create dashboard button from listing (elastic…
82f0874 
…#164476)

## Summary

original issue: elastic#163459

**Before** - Two Create Dashboard buttons on Security Dashboard

![image](https://github.com/elastic/kibana/assets/59917825/d82e7056-0df3-44b1-abeb-10da67510247)

**After** - Create dashboard button from listing is removed.
<img width="2542" alt="Screenshot 2023-08-22 at 16 45 56"
src="https://github.com/elastic/kibana/assets/6295984/ff9bc785-de2a-40b7-b414-829c8913d997">

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit d63dd9d)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 29, 2023
@jloleysens
Merge branch 'main' into run-migrations-on-migrator
44333f6 
* main: (40 commits)
  Adjust migrations and elasticsearch service settings for serverless. (elastic#165050)
  [Security Solution] expandable flyout - add investigate in timeline f… (elastic#165025)
  [SecuritySolution] Hide create dashboard button from listing (elastic#164476)
  Construct HTTP log message only if needed (elastic#165057)
  [Security Solution] expandable flyout - add no data message in entities details and entities overview components (elastic#164955)
  Add functional tests for serverless security management UIs (elastic#164886)
  [api-docs] 2023-08-29 Daily api_docs build (elastic#165056)
  [Cloud Security][CIS GCP]cis gcp now use updated gcp field name + small last minute changes (elastic#164792)
  [Security Solution] Expandable flyout - update risk classification ui in entities overview (elastic#165022)
  [Security Solution] Fixes Preconfigured Connectors not working with Assistant (elastic#164900)
  [Security Solution] Coverage Overview follow-up 2 (elastic#164986)
  [DOCS] Add cross-link for other encryption key settings (elastic#165014)
  chore(slo): general enhancement (elastic#164723)
  Revert "[SOR] Allow optionally downgrading documents with a higher version model in API READ methods" (elastic#164991)
  [OAS] Add more Elasticsearch query rule examples (elastic#164386)
  [security_solution_cypress] Add support for options in EsArchiver.load (elastic#164988)
  [Event Log] Skip setting assets to hidden in serverless (elastic#164767)
  remove unneeded usages of isErrorResponse (elastic#164609)
  [Enterprise Search] Make network drive connector platinum (elastic#165007)
  [RAM] update api key to become public (elastic#164883)
  ...
kibanamachine added a commit that referenced this pull request Aug 29, 2023
@kibanamachine @angorayc
[8.10] [SecuritySolution] Hide create dashboard button from listing (#…
c769978 
…164476) (#165065)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[SecuritySolution] Hide create dashboard button from listing
(#164476)](#164476)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-29T08:18:00Z","message":"[SecuritySolution]
Hide create dashboard button from listing (#164476)\n\n##
Summary\r\n\r\noriginal issue:
https://github.com/elastic/kibana/issues/163459\r\n\r\n\r\n**Before** -
Two Create Dashboard buttons on Security
Dashboard\r\n\r\n![image](https://github.com/elastic/kibana/assets/59917825/d82e7056-0df3-44b1-abeb-10da67510247)\r\n\r\n\r\n**After**
- Create dashboard button from listing is removed.\r\n<img
width=\"2542\" alt=\"Screenshot 2023-08-22 at 16 45
56\"\r\nsrc=\"https://github.com/elastic/kibana/assets/6295984/ff9bc785-de2a-40b7-b414-829c8913d997\">\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"d63dd9df2deebab9a4e425e8446ed3ffdc8eebb9","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","Feature:Security
Dashboards","v8.10.0","v8.11.0"],"number":164476,"url":"https://github.com/elastic/kibana/pull/164476","mergeCommit":{"message":"[SecuritySolution]
Hide create dashboard button from listing (#164476)\n\n##
Summary\r\n\r\noriginal issue:
https://github.com/elastic/kibana/issues/163459\r\n\r\n\r\n**Before** -
Two Create Dashboard buttons on Security
Dashboard\r\n\r\n![image](https://github.com/elastic/kibana/assets/59917825/d82e7056-0df3-44b1-abeb-10da67510247)\r\n\r\n\r\n**After**
- Create dashboard button from listing is removed.\r\n<img
width=\"2542\" alt=\"Screenshot 2023-08-22 at 16 45
56\"\r\nsrc=\"https://github.com/elastic/kibana/assets/6295984/ff9bc785-de2a-40b7-b414-829c8913d997\">\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"d63dd9df2deebab9a4e425e8446ed3ffdc8eebb9"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164476","number":164476,"mergeCommit":{"message":"[SecuritySolution]
Hide create dashboard button from listing (#164476)\n\n##
Summary\r\n\r\noriginal issue:
https://github.com/elastic/kibana/issues/163459\r\n\r\n\r\n**Before** -
Two Create Dashboard buttons on Security
Dashboard\r\n\r\n![image](https://github.com/elastic/kibana/assets/59917825/d82e7056-0df3-44b1-abeb-10da67510247)\r\n\r\n\r\n**After**
- Create dashboard button from listing is removed.\r\n<img
width=\"2542\" alt=\"Screenshot 2023-08-22 at 16 45
56\"\r\nsrc=\"https://github.com/elastic/kibana/assets/6295984/ff9bc785-de2a-40b7-b414-829c8913d997\">\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"d63dd9df2deebab9a4e425e8446ed3ffdc8eebb9"}}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <[email protected]>
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

@machadoum machadoum machadoum approved these changes

Assignees
No one assigned
Labels
Feature:Security Dashboards Security solution custom dashboards feature release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@angorayc @kibana-ci @elasticmachine @kibanamachine @machadoum @ThomThomson