Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.10] [Security Solution]Expandable flyout - Alert reason formatting fix (#164861) #164888

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.10:

Questions ?

Please refer to the Backport tool documentation

…lastic#164861)

## Summary

This PR handles elastic#164408

There are some cases in which Alert Renderer cannot be wrapped beyond a
minimum width. To handle those cases, this PR handles overflow
scrolling.

Below before/after video shows the differences.

| Before | After |
|--|--|
| <video
src="https://github.com/elastic/kibana/assets/7485038/6c95a74d-db85-41db-a2c6-4fc64998e82d"
/> | <video
src="https://github.com/elastic/kibana/assets/7485038/1b7944c8-66a7-4cd9-a579-06a2e0e05ebf"
/> |

### Checklist

Delete any items that are not applicable to this PR.

- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 2417b79)
@logeekal
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 25, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #25 / detection engine api security and spaces enabled - Group 8 Detection exceptions data types and operators Rule exception operators for data type keyword "is" operator should filter 2 keyword if both are set as exceptions

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4446 4453 +7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.7MB 15.7MB +27.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @logeekal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants