Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Alert reason not properly displayed in the alert details flyout #164408

Closed
Tracked by #164549
MadameSheema opened this issue Aug 22, 2023 · 3 comments
Closed
Tracked by #164549

[Security Solution] Alert reason not properly displayed in the alert details flyout #164408

MadameSheema opened this issue Aug 22, 2023 · 3 comments
Assignees
@logeekal
Labels
bug Fixes for quality problems that affect the customer experience fixed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team

Comments

@MadameSheema
Copy link
Member

Describe the bug:

  • Alert reason not properly displayed in the alert details flyout

Kibana/Elasticsearch Stack version:

  • 8.10.0 - BC1

Initial setup:

  • To have several alerts generated
  • For this specific issue, the alert was generated by an ML rule on 8.9.0 and the instance was upgraded to 8.10.

Steps to reproduce:

  1. Navigate to the alerts page
  2. Click on View details icon for the alert you want to expand the flyout
  3. Click on Show full reason

Current behavior:

Screenshot 2023-08-22 at 11 30 47
  • The alert reason information cannot be fully read.

Expected behavior:

  • The alert reason information should be fully read.
@MadameSheema MadameSheema added bug Fixes for quality problems that affect the customer experience triage_needed Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team labels Aug 22, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@christineweng christineweng mentioned this issue Aug 23, 2023
Closed
@logeekal logeekal mentioned this issue Aug 25, 2023
Merged
3 tasks
@PhilippeOberti
Copy link
Contributor

@MadameSheema this is fixed by this PR, and will be available in BC3.

logeekal added a commit that referenced this issue Aug 25, 2023
@logeekal
[Security Solution]Expandable flyout - Alert reason formatting fix (#…
2417b79 
…164861)

## Summary

This PR handles #164408

There are some cases in which Alert Renderer cannot be wrapped beyond a
minimum width. To handle those cases, this PR handles overflow
scrolling.

Below before/after video shows the differences.

| Before | After |
|--|--|
| <video
src="https://github.com/elastic/kibana/assets/7485038/6c95a74d-db85-41db-a2c6-4fc64998e82d"
/> | <video
src="https://github.com/elastic/kibana/assets/7485038/1b7944c8-66a7-4cd9-a579-06a2e0e05ebf"
/> |


### Checklist

Delete any items that are not applicable to this PR.

- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)



### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 25, 2023
@logeekal
[Security Solution]Expandable flyout - Alert reason formatting fix (e…
bfe9993 
…lastic#164861)

## Summary

This PR handles elastic#164408

There are some cases in which Alert Renderer cannot be wrapped beyond a
minimum width. To handle those cases, this PR handles overflow
scrolling.

Below before/after video shows the differences.

| Before | After |
|--|--|
| <video
src="https://github.com/elastic/kibana/assets/7485038/6c95a74d-db85-41db-a2c6-4fc64998e82d"
/> | <video
src="https://github.com/elastic/kibana/assets/7485038/1b7944c8-66a7-4cd9-a579-06a2e0e05ebf"
/> |

### Checklist

Delete any items that are not applicable to this PR.

- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 2417b79)
kibanamachine referenced this issue Aug 25, 2023
@kibanamachine @logeekal
[8.10] [Security Solution]Expandable flyout - Alert reason formatting…
9c27217 
… fix (#164861) (#164888)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Security Solution]Expandable flyout - Alert reason formatting fix
(#164861)](#164861)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-25T18:25:20Z","message":"[Security
Solution]Expandable flyout - Alert reason formatting fix (#164861)\n\n##
Summary\r\n\r\nThis PR handles
https://github.com/elastic/kibana/issues/164408\r\n\r\nThere are some
cases in which Alert Renderer cannot be wrapped beyond a\r\nminimum
width. To handle those cases, this PR handles
overflow\r\nscrolling.\r\n\r\nBelow before/after video shows the
differences.\r\n\r\n| Before | After |\r\n|--|--|\r\n|
<video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/6c95a74d-db85-41db-a2c6-4fc64998e82d\"\r\n/>
|
<video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/1b7944c8-66a7-4cd9-a579-06a2e0e05ebf\"\r\n/>
|\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n- [x] This renders correctly on smaller
devices using a responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"2417b7975139d12c275f4e5305b524983beeca17","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting:Investigations","Feature:Expandable
Flyout","v8.10.0","v8.11.0"],"number":164861,"url":"https://github.com/elastic/kibana/pull/164861","mergeCommit":{"message":"[Security
Solution]Expandable flyout - Alert reason formatting fix (#164861)\n\n##
Summary\r\n\r\nThis PR handles
https://github.com/elastic/kibana/issues/164408\r\n\r\nThere are some
cases in which Alert Renderer cannot be wrapped beyond a\r\nminimum
width. To handle those cases, this PR handles
overflow\r\nscrolling.\r\n\r\nBelow before/after video shows the
differences.\r\n\r\n| Before | After |\r\n|--|--|\r\n|
<video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/6c95a74d-db85-41db-a2c6-4fc64998e82d\"\r\n/>
|
<video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/1b7944c8-66a7-4cd9-a579-06a2e0e05ebf\"\r\n/>
|\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n- [x] This renders correctly on smaller
devices using a responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"2417b7975139d12c275f4e5305b524983beeca17"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164861","number":164861,"mergeCommit":{"message":"[Security
Solution]Expandable flyout - Alert reason formatting fix (#164861)\n\n##
Summary\r\n\r\nThis PR handles
https://github.com/elastic/kibana/issues/164408\r\n\r\nThere are some
cases in which Alert Renderer cannot be wrapped beyond a\r\nminimum
width. To handle those cases, this PR handles
overflow\r\nscrolling.\r\n\r\nBelow before/after video shows the
differences.\r\n\r\n| Before | After |\r\n|--|--|\r\n|
<video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/6c95a74d-db85-41db-a2c6-4fc64998e82d\"\r\n/>
|
<video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/1b7944c8-66a7-4cd9-a579-06a2e0e05ebf\"\r\n/>
|\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not
applicable to this PR.\r\n\r\n- [x] This renders correctly on smaller
devices using a responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"2417b7975139d12c275f4e5305b524983beeca17"}}]}]
BACKPORT-->

Co-authored-by: Jatin Kathuria <[email protected]>
@MadameSheema
Copy link
Member Author

Fixed on BC3!! Now we have a horizontal scroll letting the user see all the information :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@logeekal logeekal

Labels
bug Fixes for quality problems that affect the customer experience fixed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@logeekal @elasticmachine @PhilippeOberti @MadameSheema @christineweng