[Security Solution]Expandable flyout - Alert reason formatting fix #164861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logeekal
added
Team:Threat Hunting:Investigations
logeekal
added
the
release_note:skip
PhilippeOberti
approved these changes
Aug 25, 2023
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 25, 2023
…lastic#164861) ## Summary This PR handles elastic#164408 There are some cases in which Alert Renderer cannot be wrapped beyond a minimum width. To handle those cases, this PR handles overflow scrolling. Below before/after video shows the differences. | Before | After | |--|--| | <video src="https://github.com/elastic/kibana/assets/7485038/6c95a74d-db85-41db-a2c6-4fc64998e82d" /> | <video src="https://github.com/elastic/kibana/assets/7485038/1b7944c8-66a7-4cd9-a579-06a2e0e05ebf" /> | ### Checklist Delete any items that are not applicable to this PR. - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 2417b79)
kibanamachine
added a commit
that referenced
this pull request
Aug 25, 2023
… fix (#164861) (#164888) # Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution]Expandable flyout - Alert reason formatting fix (#164861)](#164861) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-25T18:25:20Z","message":"[Security Solution]Expandable flyout - Alert reason formatting fix (#164861)\n\n## Summary\r\n\r\nThis PR handles https://github.com/elastic/kibana/issues/164408\r\n\r\nThere are some cases in which Alert Renderer cannot be wrapped beyond a\r\nminimum width. To handle those cases, this PR handles overflow\r\nscrolling.\r\n\r\nBelow before/after video shows the differences.\r\n\r\n| Before | After |\r\n|--|--|\r\n| <video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/6c95a74d-db85-41db-a2c6-4fc64998e82d\"\r\n/> | <video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/1b7944c8-66a7-4cd9-a579-06a2e0e05ebf\"\r\n/> |\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"2417b7975139d12c275f4e5305b524983beeca17","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","Feature:Expandable Flyout","v8.10.0","v8.11.0"],"number":164861,"url":"https://github.com/elastic/kibana/pull/164861","mergeCommit":{"message":"[Security Solution]Expandable flyout - Alert reason formatting fix (#164861)\n\n## Summary\r\n\r\nThis PR handles https://github.com/elastic/kibana/issues/164408\r\n\r\nThere are some cases in which Alert Renderer cannot be wrapped beyond a\r\nminimum width. To handle those cases, this PR handles overflow\r\nscrolling.\r\n\r\nBelow before/after video shows the differences.\r\n\r\n| Before | After |\r\n|--|--|\r\n| <video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/6c95a74d-db85-41db-a2c6-4fc64998e82d\"\r\n/> | <video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/1b7944c8-66a7-4cd9-a579-06a2e0e05ebf\"\r\n/> |\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"2417b7975139d12c275f4e5305b524983beeca17"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164861","number":164861,"mergeCommit":{"message":"[Security Solution]Expandable flyout - Alert reason formatting fix (#164861)\n\n## Summary\r\n\r\nThis PR handles https://github.com/elastic/kibana/issues/164408\r\n\r\nThere are some cases in which Alert Renderer cannot be wrapped beyond a\r\nminimum width. To handle those cases, this PR handles overflow\r\nscrolling.\r\n\r\nBelow before/after video shows the differences.\r\n\r\n| Before | After |\r\n|--|--|\r\n| <video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/6c95a74d-db85-41db-a2c6-4fc64998e82d\"\r\n/> | <video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/1b7944c8-66a7-4cd9-a579-06a2e0e05ebf\"\r\n/> |\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"2417b7975139d12c275f4e5305b524983beeca17"}}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <[email protected]>
PhilippeOberti
removed
the
Feature:Expandable Flyout
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR handles #164408
There are some cases in which Alert Renderer cannot be wrapped beyond a minimum width. To handle those cases, this PR handles overflow scrolling.
Below before/after video shows the differences.
Expandable.flyout.-.reason.formatting.-.before.mov
Screen.Recording.2023-08-25.at.17.40.12.mov
Checklist
Delete any items that are not applicable to this PR.
For maintainers