Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Removing token list from text expansion model testing #164560

Merged
merged 1 commit into from
Aug 24, 2023
Merged

[ML] Removing token list from text expansion model testing #164560

merged 1 commit into from
Aug 24, 2023

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Aug 23, 2023 •
edited by kibanamachine
Loading

The tokens listed could contain sensitive words which we do not want to display to the user, in case they cause offence.
For now we can just hide this list, in case a future version of the API contains a sanitised list of tokens.

@jgowdyelastic jgowdyelastic added non-issue Indicates to automation that a pull request should not appear in the release notes :ml release_note:skip Skip the PR/issue when compiling release notes Feature:3rd Party Models ML 3rd party models v8.10.0 v8.11.0 labels Aug 23, 2023
@jgowdyelastic jgowdyelastic self-assigned this Aug 23, 2023
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner August 23, 2023 11:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB -1.2KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

peteharverson
peteharverson approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

darnautov
darnautov approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit 323878e into elastic:main Aug 24, 2023
@kibanamachine kibanamachine mentioned this pull request Aug 24, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 24, 2023
@jgowdyelastic
[ML] Removing token list from text expansion model testing (elastic#1…
e3cc794 
…64560)

The tokens listed could contain sensitive words which we do not want to
display to the user, in case they cause offence.
For now we can just hide this list, in case a future version of the API
contains a sanitised list of tokens.

(cherry picked from commit 323878e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 24, 2023
@kibanamachine @jgowdyelastic
[8.10] [ML] Removing token list from text expansion model testing (#1…
b8f9d4a 
…64560) (#164669)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[ML] Removing token list from text expansion model testing
(#164560)](#164560)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-24T08:17:41Z","message":"[ML]
Removing token list from text expansion model testing (#164560)\n\nThe
tokens listed could contain sensitive words which we do not want
to\r\ndisplay to the user, in case they cause offence.\r\nFor now we can
just hide this list, in case a future version of the API\r\ncontains a
sanitised list of
tokens.","sha":"323878e746116550b23f25269b9d65d86552fc03","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["non-issue",":ml","release_note:skip","Feature:3rd
Party
Models","v8.10.0","v8.11.0"],"number":164560,"url":"https://github.com/elastic/kibana/pull/164560","mergeCommit":{"message":"[ML]
Removing token list from text expansion model testing (#164560)\n\nThe
tokens listed could contain sensitive words which we do not want
to\r\ndisplay to the user, in case they cause offence.\r\nFor now we can
just hide this list, in case a future version of the API\r\ncontains a
sanitised list of
tokens.","sha":"323878e746116550b23f25269b9d65d86552fc03"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164560","number":164560,"mergeCommit":{"message":"[ML]
Removing token list from text expansion model testing (#164560)\n\nThe
tokens listed could contain sensitive words which we do not want
to\r\ndisplay to the user, in case they cause offence.\r\nFor now we can
just hide this list, in case a future version of the API\r\ncontains a
sanitised list of
tokens.","sha":"323878e746116550b23f25269b9d65d86552fc03"}}]}]
BACKPORT-->

Co-authored-by: James Gowdy <[email protected]>
jloleysens added a commit that referenced this pull request Aug 24, 2023
@jloleysens
Merge branch 'main' into versioned-router-and-oas
e582640 
* main: (3152 commits)
  [Security Solution][Detection Engine] fixes 410 error on index legacy template call (#164682)
  [SavedObjects] Create serverless roots for jest integration tests (#164157)
  Create upselling package and implement EntityAnalytics serverless upselling (#164136)
  [Fleet] Change 'Out-of-date' to 'Outdated policy' in agent list table (#164673)
  [IndexManagement] Use internal base path for API (#164665)
  [Profiling] removing ~ symbol (#164595)
  [Telemetry] Fetch snapshot: allow specifying the version via querystring (#164670)
  [Cases] Show warning when all cases table reaches 10k cases message (#164323)
  [ML] Removing token list from text expansion model testing (#164560)
  [Fleet] Add secrets package API integration test (#164583)
  [Fleet] Fix security solution tag id (#164582)
  [Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule (#163908)
  [api-docs] 2023-08-24 Daily api_docs build (#164658)
  [APM] Cleanup alerting api tests (#164438)
  Upgrade EUI to 87.2.0 (#164385)
  [ML] Fix query bar autocompletion for ML and AIOps embeddables (#164485)
  [Fleet] Fix flaky unit test for the details page (#164641)
  [Security Solution] update codeowner for serverless security subdir (#164640)
  [Security Solution] Fixes Assistant Connector and Actions RBAC Flow (#164382)
  [Discover] Removing large string truncation from doc viewer (#164236)
  ...
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov darnautov approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
Feature:3rd Party Models ML 3rd party models :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgowdyelastic @elasticmachine @kibana-ci @kibanamachine @darnautov @peteharverson