Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixes query bar autocompletion for ML and AIOps embeddables #164485

Merged
merged 7 commits into from
Aug 23, 2023
Merged

[ML] Fixes query bar autocompletion for ML and AIOps embeddables #164485

merged 7 commits into from
Aug 23, 2023

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Aug 22, 2023 •
edited by kibanamachine
Loading

Summary

Closes #163415

Adds defer loading for Anomaly swim lane, Anomaly charts and Change point detection embeddables and outputs data views to fix query and filter autocompletion after embedding in the Dashboard app.

Checklist

@darnautov darnautov added release_note:fix :ml Feature:Anomaly Detection ML anomaly detection Team:ML Team label for ML (also use :ml) v8.10.0 Feature:Embeddables Relating to the Embeddable system v8.11.0 labels Aug 22, 2023
@darnautov darnautov self-assigned this Aug 22, 2023
@darnautov darnautov requested a review from a team as a code owner August 22, 2023 17:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@qn895
Copy link
Member

qn895 commented Aug 22, 2023

Tested change point detection, anomaly swimlane, anomaly charts embeddables and LGTM. Wondering if there's anything we can do to get the autocomplete to populate with suggestions for keywords. For example, with the current fix, instance is not showing list of suggestions even though we know data do exist:

Screen.Recording.2023-08-22.at.14.36.01.mov

With another dashboard:

Screen Shot 2023-08-22 at 14 34 53

@darnautov
Copy link
Contributor Author

Tested change point detection, anomaly swimlane, anomaly charts embeddables and LGTM. Wondering if there's anything we can do to get the autocomplete to populate with suggestions for keywords. For example, with the current fix, instance is not showing list of suggestions even though we know data do exist:

Screen.Recording.2023-08-22.at.14.36.01.mov
With another dashboard:

Screen Shot 2023-08-22 at 14 34 53

@qn895 Thanks for testing! I assume keyword autocompletion is something to do with mappings. I added an embeddable with logs_categorization job using the kibana_sample_data_logs index and it works.

image

@darnautov darnautov requested a review from qn895 August 23, 2023 07:35
@darnautov darnautov changed the title [ML] Fix data views output for ML and AIOps embeddables [ML] Fix query bar autocompletion for ML and AIOps embeddables Aug 23, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 1793 1794 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 595.3KB 595.4KB +161.0B
ml 3.5MB 3.5MB +1.7KB
total +1.8KB
Unknown metric groups

References to deprecated APIs

id before after diff
ml 176 171 -5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

peteharverson
peteharverson approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest changes and LGTM

@darnautov darnautov merged commit 5d5ac37 into elastic:main Aug 23, 2023
@darnautov darnautov deleted the ml-163415-embeddables-data-views branch August 23, 2023 22:08
@kibanamachine kibanamachine mentioned this pull request Aug 23, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2023
@darnautov
[ML] Fix query bar autocompletion for ML and AIOps embeddables (elast…
be50f81 
…ic#164485)

(cherry picked from commit 5d5ac37)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 23, 2023
@kibanamachine @darnautov
[8.10] [ML] Fix query bar autocompletion for ML and AIOps embeddables (…
916b1eb 
…#164485) (#164647)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[ML] Fix query bar autocompletion for ML and AIOps embeddables
(#164485)](#164485)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-23T22:08:23Z","message":"[ML]
Fix query bar autocompletion for ML and AIOps embeddables
(#164485)","sha":"5d5ac37e9e7a36f359a78d1af7a89ce324c3194f","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:Anomaly
Detection","Team:ML","v8.10.0","Feature:Embeddables","v8.11.0"],"number":164485,"url":"https://github.com/elastic/kibana/pull/164485","mergeCommit":{"message":"[ML]
Fix query bar autocompletion for ML and AIOps embeddables
(#164485)","sha":"5d5ac37e9e7a36f359a78d1af7a89ce324c3194f"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164485","number":164485,"mergeCommit":{"message":"[ML]
Fix query bar autocompletion for ML and AIOps embeddables
(#164485)","sha":"5d5ac37e9e7a36f359a78d1af7a89ce324c3194f"}}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <[email protected]>
jloleysens added a commit that referenced this pull request Aug 24, 2023
@jloleysens
Merge branch 'main' into versioned-router-and-oas
e582640 
* main: (3152 commits)
  [Security Solution][Detection Engine] fixes 410 error on index legacy template call (#164682)
  [SavedObjects] Create serverless roots for jest integration tests (#164157)
  Create upselling package and implement EntityAnalytics serverless upselling (#164136)
  [Fleet] Change 'Out-of-date' to 'Outdated policy' in agent list table (#164673)
  [IndexManagement] Use internal base path for API (#164665)
  [Profiling] removing ~ symbol (#164595)
  [Telemetry] Fetch snapshot: allow specifying the version via querystring (#164670)
  [Cases] Show warning when all cases table reaches 10k cases message (#164323)
  [ML] Removing token list from text expansion model testing (#164560)
  [Fleet] Add secrets package API integration test (#164583)
  [Fleet] Fix security solution tag id (#164582)
  [Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule (#163908)
  [api-docs] 2023-08-24 Daily api_docs build (#164658)
  [APM] Cleanup alerting api tests (#164438)
  Upgrade EUI to 87.2.0 (#164385)
  [ML] Fix query bar autocompletion for ML and AIOps embeddables (#164485)
  [Fleet] Fix flaky unit test for the details page (#164641)
  [Security Solution] update codeowner for serverless security subdir (#164640)
  [Security Solution] Fixes Assistant Connector and Actions RBAC Flow (#164382)
  [Discover] Removing large string truncation from doc viewer (#164236)
  ...
@kdelemme kdelemme mentioned this pull request Oct 1, 2023
Merged
@peteharverson peteharverson changed the title [ML] Fix query bar autocompletion for ML and AIOps embeddables [ML] Fixes query bar autocompletion for ML and AIOps embeddables Oct 4, 2023
@kdelemme kdelemme mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qn895 qn895 qn895 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@darnautov darnautov

Labels
Feature:Anomaly Detection ML anomaly detection Feature:Embeddables Relating to the Embeddable system :ml release_note:fix Team:ML Team label for ML (also use :ml) v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Query and filters autocompletion in the Dashboard app with ML embeddables
6 participants
@darnautov @elasticmachine @qn895 @kibana-ci @kibanamachine @peteharverson