Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to 87.2.0 #164385

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Upgrade EUI to 87.2.0 #164385

merged 3 commits into from
Aug 23, 2023

Conversation

breehall
Copy link
Contributor

87.1.0 ➡️ 87.2.0

87.2.0

  • EuiResizableButton is now available as a generic top-level export (#7087)
  • Added new alignIndicator prop to EuiResizableButton. Defaults to center, and can now additionally be configured to start and end (#7087)
  • Updated useGeneratedHtmlId hook to use React.useId as the source of unique identifiers when available (#7095)

CSS-in-JS conversions

  • Converted EuiResizableButton to Emotion; Removed $euiResizableButtonTransitionSpeed and $euiResizableButtonSize (#7081)
  • Converted EuiResizableCollapseButton to Emotion (#7091)

@breehall breehall added release_note:skip Skip the PR/issue when compiling release notes EUI v8.11.0 labels Aug 22, 2023
breehall and others added 2 commits August 22, 2023 09:42
@breehall
Update i18n tokens for eui/87.2.0
bcbd78d
@cee-chen
[EuiResizableButton] Remove CSS specificity overrides
cb2846e 
- now that the component has been converted to Emotion, its styles are flat and will automatically be overridden by subsequent styles
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.0MB 2.0MB +1.1KB
securitySolution 15.7MB 15.7MB +6.4KB
securitySolutionServerless 249.0KB 255.3KB +6.2KB
unifiedHistogram 46.7KB 46.7KB -60.0B
visTypeVega 1.8MB 1.8MB +1.1KB
total +14.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 379.4KB 379.5KB +30.0B
kbnUiSharedDeps-css 291.0KB 284.1KB -6.8KB
kbnUiSharedDeps-npmDll 6.2MB 6.2MB +6.1KB
kbnUiSharedDeps-srcJs 2.2MB 2.2MB -1.0B
securitySolutionServerless 37.9KB 37.9KB +2.0B
total -743.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@breehall breehall marked this pull request as ready for review August 22, 2023 16:49
@breehall breehall requested review from a team as code owners August 22, 2023 16:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

afharo
afharo approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core (Localization) changes LGTM

mattkime
mattkime approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm

@breehall breehall merged commit 950ac6e into elastic:main Aug 23, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 23, 2023
jloleysens added a commit that referenced this pull request Aug 24, 2023
@jloleysens
Merge branch 'main' into versioned-router-and-oas
e582640 
* main: (3152 commits)
  [Security Solution][Detection Engine] fixes 410 error on index legacy template call (#164682)
  [SavedObjects] Create serverless roots for jest integration tests (#164157)
  Create upselling package and implement EntityAnalytics serverless upselling (#164136)
  [Fleet] Change 'Out-of-date' to 'Outdated policy' in agent list table (#164673)
  [IndexManagement] Use internal base path for API (#164665)
  [Profiling] removing ~ symbol (#164595)
  [Telemetry] Fetch snapshot: allow specifying the version via querystring (#164670)
  [Cases] Show warning when all cases table reaches 10k cases message (#164323)
  [ML] Removing token list from text expansion model testing (#164560)
  [Fleet] Add secrets package API integration test (#164583)
  [Fleet] Fix security solution tag id (#164582)
  [Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule (#163908)
  [api-docs] 2023-08-24 Daily api_docs build (#164658)
  [APM] Cleanup alerting api tests (#164438)
  Upgrade EUI to 87.2.0 (#164385)
  [ML] Fix query bar autocompletion for ML and AIOps embeddables (#164485)
  [Fleet] Fix flaky unit test for the details page (#164641)
  [Security Solution] update codeowner for serverless security subdir (#164640)
  [Security Solution] Fixes Assistant Connector and Actions RBAC Flow (#164382)
  [Discover] Removing large string truncation from doc viewer (#164236)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

@jbudz jbudz jbudz approved these changes

@mattkime mattkime mattkime approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@breehall @kibana-ci @elasticmachine @mattkime @jbudz @afharo @kibanamachine @cee-chen