Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Update insight depth limit to 1 #161901

Merged
merged 2 commits into from
Jul 13, 2023
Merged

[Security Solution] Update insight depth limit to 1 #161901

merged 2 commits into from
Jul 13, 2023

Conversation

kqualters-elastic
Copy link
Contributor

@kqualters-elastic kqualters-elastic commented Jul 13, 2023 •
edited by kibanamachine
Loading

Summary

Before #160691 was merged, the filter builder depth of 1 was the same as 0, and so I mistakenly had this value set to 2. With it set to 2, it's possible to create a filter with top level AND and 2 levels of nesting that will cause the designed for only 1 level of nesting data provider code to throw a run time error. Setting this to the now working level of 1 prevents that.

@kqualters-elastic kqualters-elastic added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.9.0 labels Jul 13, 2023
@kqualters-elastic kqualters-elastic requested a review from a team as a code owner July 13, 2023 18:53
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Explore - Security Solution Tests #2 / Entity Analytics Dashboard With anomalies data enables a job

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 490 494 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kqualters-elastic kqualters-elastic merged commit 97705ff into elastic:main Jul 13, 2023
@kqualters-elastic kqualters-elastic deleted the insight-depth-limit branch July 13, 2023 20:28
@kibanamachine kibanamachine mentioned this pull request Jul 13, 2023
Open
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 13, 2023
@kqualters-elastic
[Security Solution] Update insight depth limit to 1 (elastic#161901)
25c3fed 
## Summary

Before elastic#160691 was merged, the
filter builder depth of 1 was the same as 0, and so I mistakenly had
this value set to 2. With it set to 2, it's possible to create a filter
with top level AND and 2 levels of nesting that will cause the designed
for only 1 level of nesting data provider code to throw a run time
error. Setting this to the now working level of 1 prevents that.

(cherry picked from commit 97705ff)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Jul 13, 2023
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 21, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

5 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@jbudz jbudz added the backport:skip This commit does not require backporting label Sep 30, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.9.0 v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kqualters-elastic @kibana-ci @kibanamachine @michaelolo24 @jbudz