Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.9] [Security Solution] Update insight depth limit to 1 (#161901) #161911

Open
wants to merge 1 commit into
base: 8.9
Choose a base branch
from
Open

[8.9] [Security Solution] Update insight depth limit to 1 (#161901) #161911

wants to merge 1 commit into from
+1 −1

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.9:

Questions ?

Please refer to the Backport tool documentation

@kqualters-elastic
[Security Solution] Update insight depth limit to 1 (elastic#161901)
25c3fed 
## Summary

Before elastic#160691 was merged, the
filter builder depth of 1 was the same as 0, and so I mistakenly had
this value set to 2. With it set to 2, it's possible to create a filter
with top level AND and 2 levels of nesting that will cause the designed
for only 1 level of nesting data provider code to throw a run time
error. Setting this to the now working level of 1 prevents that.

(cherry picked from commit 97705ff)
@kibanamachine kibanamachine enabled auto-merge (squash) July 13, 2023 20:35
@kibanamachine kibanamachine mentioned this pull request Jul 13, 2023
Merged
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jul 13, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Explore - Security Solution Tests #2 / Entity Analytics Dashboard With anomalies data enables a job
  • [job] [logs] Explore - Security Solution Tests #2 / Hover actions Adds global filter - filter in

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 415 419 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 496 500 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kqualters-elastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@kqualters-elastic kqualters-elastic

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @kibana-ci @kqualters-elastic