Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Add missing settings to documentation #161603

Merged
merged 7 commits into from
Jul 13, 2023

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Jul 10, 2023

Summary

This PR adds missing APM/Observability settings to the documentation:

  • observability:apmAgentExplorerView
  • observability:apmAWSLambdaPriceFactor
  • observability:apmAWSLambdaRequestCostPerMillion
  • observability:apmEnableContinuousRollups
  • observability:apmEnableServiceMetrics
  • observability:apmLabsButton
  • observability:apmServiceGroupMaxNumberOfServices
  • observability:apmDefaultServiceEnvironment

This PR also adds @elastic/obs-docs as a codeowner to /x-pack/plugins/observability/server/ui_settings.ts so that we don't miss documenting settings moving forward.

Closes #118795.

@bmorelli25 bmorelli25 self-assigned this Jul 10, 2023
@github-actions
Copy link
Contributor

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@bmorelli25 bmorelli25 added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes v8.9.0 v8.8.2 labels Jul 10, 2023
@bmorelli25 bmorelli25 marked this pull request as ready for review July 10, 2023 21:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@bmorelli25 bmorelli25 requested a review from a team July 10, 2023 21:52
Comment on lines 402 to 403
[[apm-aws-request]]`observability:apmAWSLambdaRequestCostPerMillion`::
??
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cauemarcondes what does this config do? I couldn't figure it out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used to calculate the cost running on serverless:

const estimatedCost =
computeUsageGbSec * priceFactor +
transactionThroughput * (awsLambdaRequestCostPerMillion / 1000000);

The price is the number of requests (throughput) multipled with the AWS Lambda request cost (currently the monthly request price is $0.20 per one million request)

@bmorelli25 bmorelli25 enabled auto-merge (squash) July 13, 2023 22:19
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 490 494 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bmorelli25

@bmorelli25 bmorelli25 merged commit d728789 into elastic:main Jul 13, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.8 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.8:
- Clarify documentation for the observability:enableComparisonByDefault setting (#161372)
- [APM] Documentation updates (#160951)
8.9 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.9:
- [Security Solution] Update insight depth limit to 1 (#161901)

Manual backport

To create the backport manually run:

node scripts/backport --pr 161603

Questions ?

Please refer to the Backport tool documentation

@bmorelli25
Copy link
Member Author

Backported manually in #161925 and #161926

bmorelli25 added a commit to bmorelli25/kibana that referenced this pull request Jul 14, 2023
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 21, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 161603 locally

@bmorelli25 bmorelli25 added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.8.2 v8.9.0 v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Document APM settings from Kibana Advanced Settings
6 participants