Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v80.0.0 #157939

Merged
merged 5 commits into from
May 18, 2023
Merged

Upgrade EUI to v80.0.0 #157939

merged 5 commits into from
May 18, 2023

Conversation

tkajtoch
Copy link
Member

@tkajtoch tkajtoch commented May 16, 2023 •
edited by kibanamachine
Loading

Summary

@elastic/[email protected] ⏩ @elastic/[email protected]

80.0.0

  • Improved the contrast ratio of meta labels within EuiSelectableTemplateSitewide to meet WCAG AA guidelines. (#6761)
  • Added vulnerabilityManagementApp glyph to EuiIcon (#6762)
  • Added logoVulnerabilityManagement icon to EuiIcon (#6763)
  • Added onPanelChange callback to EuiContextMenu to provide consumer access to panelId and direction. (#6767)

Bug fixes

  • Fixed EuiComboBox so append and prepend icon buttons are full height and vertically centered. (#6766)
  • Improved the uniformity of dropdown components by hiding the dropdown icon of disabled EuiComboBoxs. (#6768)

Breaking changes

  • EuiFieldNumber now defaults the step prop to "any" (#6760)
  • EUI now globally resets a default Chromium browser style that was decreasing the opacity of disabled select items. (#6768)

@tkajtoch tkajtoch added release_note:skip Skip the PR/issue when compiling release notes EUI labels May 16, 2023
@tkajtoch tkajtoch self-assigned this May 16, 2023
@tkajtoch tkajtoch force-pushed the eui-v80.0 branch 2 times, most recently from a4cb95a to 5f3f79f Compare May 17, 2023 14:51
@tkajtoch tkajtoch marked this pull request as ready for review May 17, 2023 18:49
@tkajtoch tkajtoch requested review from a team as code owners May 17, 2023 18:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

cee-chen
cee-chen reviewed May 17, 2023
View reviewed changes
...s/maps/public/connected_components/toolbar_overlay/set_view_control/decimal_degrees_form.tsx
@@ -90,7 +90,6 @@ export class DecimalDegreesForm extends Component<Props, State> {
onChange={this._onLatChange}
isInvalid={isLatInvalid}
data-test-subj="latitudeInput"
step="any" // Browsers will validate decimals as invalid otherwise
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context for this reversion, EuiFieldNumber now defaults to step="any", so all decimal number inputs will no longer have invalid states (although you're still of course free to pass in your own custom step interval, e.g. step={0.5}

nreese
nreese approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-gis changes LGTM
code review only

@nreese nreese mentioned this pull request May 17, 2023
Closed
@tkajtoch
Copy link
Member Author

@elasticmachine merge upstream

peteharverson
peteharverson approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML functional test change LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #1 / Cases Creates a new case with timeline and opens the timeline
  • [job] [logs] Security Solution Tests #1 / Entity Analytics Dashboard With anomalies data enables a job

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.0MB 2.0MB +27.0B
maps 2.7MB 2.7MB -33.0B
visTypeVega 1.7MB 1.7MB +27.0B
total +21.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-css 313.2KB 313.2KB +42.0B
kbnUiSharedDeps-npmDll 5.9MB 5.9MB +593.0B
total +635.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tkajtoch

@tkajtoch tkajtoch merged commit b754a2d into elastic:main May 18, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.8 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 157939

Questions ?

Please refer to the Backport tool documentation

@cee-chen cee-chen removed the v8.8.1 label May 18, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 18, 2023
delanni pushed a commit to delanni/kibana that referenced this pull request May 25, 2023
@tkajtoch @kibanamachine @delanni
Upgrade EUI to v80.0.0 (elastic#157939)
030da3b 
## Summary

`@elastic/[email protected]` ⏩ `@elastic/[email protected]`

---

## [`80.0.0`](https://github.com/elastic/eui/tree/v80.0.0)

- Improved the contrast ratio of meta labels within
`EuiSelectableTemplateSitewide` to meet WCAG AA guidelines.
([elastic#6761](elastic/eui#6761))
- Added `vulnerabilityManagementApp` glyph to `EuiIcon`
([elastic#6762](elastic/eui#6762))
- Added `logoVulnerabilityManagement` icon to `EuiIcon`
([elastic#6763](elastic/eui#6763))
- Added `onPanelChange` callback to `EuiContextMenu` to provide consumer
access to `panelId` and `direction`.
([elastic#6767](elastic/eui#6767))

**Bug fixes**

- Fixed `EuiComboBox` so `append` and `prepend` icon buttons are full
height and vertically centered.
([elastic#6766](elastic/eui#6766))
- Improved the uniformity of dropdown components by hiding the dropdown
icon of disabled `EuiComboBox`s.
([elastic#6768](elastic/eui#6768))

**Breaking changes**

- `EuiFieldNumber` now defaults the `step` prop to `"any"`
([elastic#6760](elastic/eui#6760))
- EUI now globally resets a default Chromium browser style that was
decreasing the opacity of disabled `select` items.
([elastic#6768](elastic/eui#6768))

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-chen cee-chen cee-chen left review comments

@nreese nreese nreese approved these changes

@jbudz jbudz jbudz approved these changes

@peteharverson peteharverson peteharverson approved these changes

@yctercero yctercero yctercero approved these changes

Assignees

@tkajtoch tkajtoch

Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tkajtoch @elasticmachine @kibana-ci @kibanamachine @nreese @cee-chen @jbudz @peteharverson @yctercero